Skip to content

Fix logic to declare incompatibility with configuration cache #3438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
whyoleg merged 1 commit into from
Jan 19, 2024
Merged

Fix logic to declare incompatibility with configuration cache #3438

whyoleg merged 1 commit into from
Jan 19, 2024

Conversation

@3flex
Copy link
Contributor

@3flex 3flex commented Dec 30, 2023 •
edited
Loading

The existing logic does not work correctly (at least on Gradle 8.5) because the name of the first parameter of notCompatibleWithConfigurationCache method evaluates to null, not reason, so containsNotCompatibleWithConfigurationCache incorrectly evaluates to false.

This PR removes unnecessary reflection and corrects the logic.

@3flex 3flex mentioned this pull request Dec 30, 2023
Merged
whyoleg
whyoleg approved these changes Jan 19, 2024
View reviewed changes
Copy link
Collaborator

@whyoleg whyoleg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Thank you for the PR! Somehow we missed it earlier.
LGTM!
I've additionally checked, that with this fix everything works as expected on both artificial projects on different Gradle version with both enabled/disabled configuration cache and real ones (like detekt) - everything works fine.

@whyoleg whyoleg merged commit 205a96a into Kotlin:master Jan 19, 2024
@3flex 3flex deleted the patch-1 branch January 19, 2024 12:48
@IgnatBeresnev IgnatBeresnev added this to the Dokka 1.9.20 milestone Jan 19, 2024
whyoleg pushed a commit that referenced this pull request Jan 19, 2024
@3flex @whyoleg
Fix logic to declare incompatibility with configuration cache (#3438)
fdff1ed 
(cherry picked from commit 205a96a)
github-merge-queue bot referenced this pull request in slackhq/foundry Mar 5, 2024
@slack-oss-bot
Update dependency org.jetbrains.dokka to v1.9.20 (#765)
41ac36a 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [org.jetbrains.dokka](https://togithub.com/Kotlin/dokka) | plugin |
patch | `1.9.10` -> `1.9.20` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>Kotlin/dokka (org.jetbrains.dokka)</summary>

### [`v1.9.20`](https://togithub.com/Kotlin/dokka/releases/tag/v1.9.20):
1.9.20

#### General bugfixes

- Fixed sealed interfaces not having the `sealed` keyword in signatures
([https://github.com/Kotlin/dokka/issues/2994](https://togithub.com/Kotlin/dokka/issues/2994))
- Fixed incorrect links in multi-module projects with non-unique package
names
([https://github.com/Kotlin/dokka/issues/2272](https://togithub.com/Kotlin/dokka/issues/2272)).
Huge thanks to [@&#8203;EddieRingle](https://togithub.com/EddieRingle)!
- Fixed member extensions not being shown on index pages in certain
scenarios
([https://github.com/Kotlin/dokka/issues/3187](https://togithub.com/Kotlin/dokka/issues/3187))
- Fixed Java's inner classes not having the `inner` keyword in Kotlin
signatures
([