Skip to content

Make compatible with Gradle 9 #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 1, 2025
Merged

Make compatible with Gradle 9 #310

merged 2 commits into from
Aug 1, 2025

Conversation

ganadist
Copy link
Contributor

@ganadist ganadist commented Jun 17, 2025 •
edited
Loading

Fix #309

Bytecode of plugin refer groovy.util.XmlSlurper, but this class is not accessible in Groovy 4 runtime.
Added import statement to use groovy.xml.XmlSlurper class which is available on Groovy 3 and 4 runtime.
ref :

  • AS-IS
$ javap -c -cp oss-licenses-plugin-0.10.6.jar com.google.android.gms.oss.licenses.plugin.LicensesTask | grep XmlSlurper
     259: ldc_w         #488                // class groovy/util/XmlSlurper
  • TO-BE
$ javap -c -cp oss-licenses-plugin-0.10.6.jar com.google.android.gms.oss.licenses.plugin.LicensesTask | grep XmlSlurper
     260: ldc_w         #488                // class groovy/xml/XmlSlurper

@VinayGuthal VinayGuthal requested a review from davidmotson July 31, 2025 21:14
@davidmotson davidmotson merged commit c9a5842 into google:main Aug 1, 2025
4 checks passed
@SimonMarquis SimonMarquis mentioned this pull request Aug 1, 2025
Closed
@marekdef marekdef mentioned this pull request Aug 5, 2025
Closed
@heftisun
Copy link

.

@boyloveman1992-droid
Copy link

[email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidmotson davidmotson davidmotson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OSS License plugin is not compatible with Gradle 9
4 participants
@ganadist @heftisun @boyloveman1992-droid @davidmotson