Save presets #2
Open
Save presets #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds -P command line option to define default path where to save presets. Adds "save preset" command. Note: qt does not have command line parameters implemented.
Remove command line to set save path. Implements saving preset with banks.
Show bank when listing presets. Don't suffix preset path with plugin name (wip).
Remove plugin name from preset / bank path. Remove debug output.
|
I am not authorised to merge this PR. Once merged I will move my working copy to the zynthian fork and delete my fork. |
|
Note: These commits act on jalv_console. After the merge and I start working on zynthian fork I will implement on java_gtk too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes work on preset management in fork. Further work to be done within zynthian fork.