From my current understanding of SAX parsers, I think the code in lib/sax.js is doing some things out of it's scope:

Lines 90 to 93 in cad05a1

    
           var doc = domBuilder.doc; 
        
           			var text = doc.createTextNode(source.substr(start)); 
        
           			doc.appendChild(text); 
        
           			domBuilder.currentElement = text;

var doc = domBuilder.doc;
var text = doc.createTextNode(source.substr(start));
doc.appendChild(text);
domBuilder.currentElement = text;

which tightly couples it to the current implementations of DOMHandler in lib/dom-parser.js and DOMImplementation in lib/dom.js.

Another place of coupling is here

domBuilder.locator = ...

which again tightly couples it to the current implementations of DOMHandler in lib/dom-parser.js.

Before switching to another sax parser we would need to fix that (without breaking anything of course).

I think my approach to write tests just for lib/sax.js that can later also be executed against other SAX parsers is still valid I think and will reveal more details.

	var doc = domBuilder.doc;
	var text = doc.createTextNode(source.substr(start));
	doc.appendChild(text);
	domBuilder.currentElement = text;

replace lib/sax.js? #55

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions