Skip to content

Offline Pages - Design Review [DO NOT MERGE] #11464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Offline Pages - Design Review [DO NOT MERGE] #11464

wants to merge 1 commit into from

Conversation

jd-alexander
Copy link
Contributor

@jd-alexander jd-alexander commented Mar 18, 2020 •
edited by malinajirka
Loading

Findings

Below are several UI/UX changes that were done to make the Page List offline behavior similar to the Post List.

Design Changes

Edit Offline - Changes Not Confirmed

Before - Page List After - Page List Post List
  • Updated label color from grey to yellow
  • Moved the label to a separate line so even longer labels can fit the screen

Edit Offline - Changes Confirmed

Before - Page List After - Page List Post List
  • Enabled auto-upload
  • Updated the label from "Local changes" to "We'll publish the page when your device is back online."
  • Added Snackbar with the same message

Publish Progress - Internet Restored

Before - Page List After - Page List Post List
  • Added support for automatic autoupload when internet connection is restored
  • Added progress indicator
  • Added semi-transparent overlay which prevents the user from opening the page
  • Added "Uploading page" label

Publish Media Progress - Internet Restored

Before - Page List After - Page List Post List
  • Added progress indicator
  • Added "Uploading media..." label

Publish Media Failed - less than 3 times

Before - Page List After - Page List Post List
  • Added "We couldn't publish this page, but we'll try again later."

Publish Media Failed - more than 3 times

Before - Page List After - Page List Post List
  • Added "We couldn't upload this media, and didn't publish the page." label

Cancel auto-upload

Before - Page List After - Page List Post List
  • Added "Cancel autoupload" action - autoupload wasn't previously supported

Search Mode

Before - Page List After - Page List Post List
  • Started showing labels even in search

Scroll To Page When Publish Draft

Before - Page List After - Page List Post List
  • The app automatically scrolls to the page user just published

Scroll To Page When Publish From Editor

Before - Page List After - Page List Post List
  • The app automatically scrolls to the page user just published

Unhandled autosave labels

Before - Page List After - Page List Post List
  • Added support for unhandled auto save label

Unhandled autosave dialogs

Before - Page List After - Page List Post List
.
  • Introduced "Unhandled autosave" dialog so user can load autosave revision

@jd-alexander
DO NOT MERGE.
b143c23 
Pushed random change so PR could be created.
@jd-alexander jd-alexander added this to the 14.5 milestone Mar 18, 2020
@peril-wordpress-mobile
Copy link

You can test the changes on this Pull Request by downloading the APK here.

@jd-alexander
Copy link
Contributor Author

@malinajirka I started the design review. Let me know if the format is okay. Thanks 🙏

@malinajirka
Copy link
Contributor

Noticed that the label on the Post List when a post is updated says "locally changed". Is that the correct label or should it be the same as the Page List copy?

If the changes were confirmed, it should match the page list. I'm wondering if perhaps the snackbar is related to a different post and the post with "local changes" label wasn't confirmed. Wdyt?

Let me know if the format is okay.

Yes, thank you! I'd consider using the "collapsed" view on the post list on the future images. It's not a big deal and I definitely wouldn't worry about updating the images you already took. Wdyt?

@jd-alexander
Copy link
Contributor Author

jd-alexander commented Mar 19, 2020 •
edited
Loading

If the changes were confirmed, it should match the page list. I'm wondering if perhaps the snackbar is related to a different post and the post with "local changes" label wasn't confirmed. Wdyt?

True. It's working fine now. It probably occurred due to the upload status cache issue.

Yes, thank you! I'd consider using the "collapsed" view on the post list on the future images. It's not a big deal and I definitely wouldn't worry about updating the images you already took. Wdyt?

That's a good idea! I didn't even remember I could do that 🙏

@malinajirka malinajirka modified the milestones: 14.5, 14.6 Mar 23, 2020
@jd-alexander jd-alexander deleted the offline-pages-design-review branch May 4, 2020 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Offline Support Posts + Pages

Projects

None yet

Milestone

14.6

Development

Successfully merging this pull request may close these issues.

2 participants

@jd-alexander @malinajirka