Skip to content

Commit 97fe60b

Browse files
committed
Revert "Added dismissAfterConfirm flag."
This reverts commit 8817437.
1 parent acf156e commit 97fe60b

File tree

1 file changed

+1
-29
lines changed

1 file changed

+1
-29
lines changed

WordPress/src/main/java/org/wordpress/android/ui/FullScreenDialogFragment.java

Lines changed: 1 addition & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -48,12 +48,10 @@ public class FullScreenDialogFragment extends DialogFragment {
4848
private String mTitle;
4949
private Toolbar mToolbar;
5050
private boolean mHideActivityBar;
51-
private boolean mDismissAfterConfirm;
5251
private int mToolbarColor;
5352

5453
private static final String ARG_ACTION = "ARG_ACTION";
5554
private static final String ARG_HIDE_ACTIVITY_BAR = "ARG_HIDE_ACTIVITY_BAR";
56-
private static final String ARG_DISMISS_AFTER_CONFIRM = "ARG_DISMISS_AFTER_CONFIRM";
5755
private static final String ARG_SUBTITLE = "ARG_SUBTITLE";
5856
private static final String ARG_TITLE = "ARG_TITLE";
5957
private static final String ARG_TOOLBAR_COLOR = "ARG_TOOLBAR_COLOR";
@@ -92,7 +90,6 @@ protected static FullScreenDialogFragment newInstance(Builder builder) {
9290
dialog.setOnConfirmListener(builder.mOnConfirmListener);
9391
dialog.setOnDismissListener(builder.mOnDismissListener);
9492
dialog.setHideActivityBar(builder.mHideActivityBar);
95-
dialog.setDismissAfterConfirm(builder.mDismissAfterConfirm);
9693
return dialog;
9794
}
9895

@@ -103,7 +100,6 @@ private static Bundle setArguments(Builder builder) {
103100
bundle.putString(ARG_SUBTITLE, builder.mSubtitle);
104101
bundle.putInt(ARG_TOOLBAR_COLOR, builder.mToolbarColor);
105102
bundle.putBoolean(ARG_HIDE_ACTIVITY_BAR, builder.mHideActivityBar);
106-
bundle.putBoolean(ARG_DISMISS_AFTER_CONFIRM, builder.mDismissAfterConfirm);
107103
return bundle;
108104
}
109105

@@ -220,9 +216,7 @@ protected void confirm(Bundle result) {
220216
mOnConfirmListener.onConfirm(result);
221217
}
222218

223-
if (mDismissAfterConfirm) {
224-
dismiss();
225-
}
219+
dismiss();
226220
}
227221

228222
/**
@@ -259,7 +253,6 @@ private void initBuilderArguments() {
259253
mSubtitle = bundle.getString(ARG_SUBTITLE);
260254
mToolbarColor = bundle.getInt(ARG_TOOLBAR_COLOR);
261255
mHideActivityBar = bundle.getBoolean(ARG_HIDE_ACTIVITY_BAR);
262-
mDismissAfterConfirm = bundle.getBoolean(ARG_DISMISS_AFTER_CONFIRM);
263256
}
264257

265258
/**
@@ -382,15 +375,6 @@ public void setSubtitle(@StringRes int textId) {
382375
}
383376
}
384377

385-
/**
386-
* Set flag to dismiss fragment after confirm action is clicked.
387-
*
388-
* @param dismissAfterConfirm boolean to dismiss after confirm click.
389-
*/
390-
public void setDismissAfterConfirm(boolean dismissAfterConfirm) {
391-
mDismissAfterConfirm = dismissAfterConfirm;
392-
}
393-
394378
/**
395379
* Set theme background for {@link FullScreenDialogFragment} view.
396380
*
@@ -437,7 +421,6 @@ public static class Builder {
437421
String mSubtitle = "";
438422
String mTitle = "";
439423
boolean mHideActivityBar = false;
440-
boolean mDismissAfterConfirm = true;
441424
int mToolbarColor = R.color.primary;
442425

443426
/**
@@ -509,17 +492,6 @@ public Builder setHideActivityBar(boolean hide) {
509492
return this;
510493
}
511494

512-
/**
513-
* Set flag to dismiss the fragment after confirm action is clicked.
514-
*
515-
* @param dismiss boolean to dismiss the fragment after confirm click.
516-
* @return {@link Builder} object to allow for chaining of calls to set methods
517-
*/
518-
public Builder setDismissAferConfirm(boolean dismiss) {
519-
this.mDismissAfterConfirm = dismiss;
520-
return this;
521-
}
522-
523495
/**
524496
* Set {@link FullScreenDialogFragment} subtitle text.
525497
*

0 commit comments

Comments
 (0)