Looks good - I wonder whether we should create a minimal image to serve as the base for this volume container though? Otherwise we'll be keeping an old version (currently ~70mb) of the weavexec image lying around. A minimal image is only 28 bytes:

vagrant@vagrant-ubuntu-wily-64:~/minvol$ cat Dockerfile 
FROM scratch
ADD . /weavedb
vagrant@vagrant-ubuntu-wily-64:~/minvol$ docker build -t foo/bar .
Sending build context to Docker daemon 2.048 kB
Step 1 : FROM scratch
 ---> 
Step 2 : ADD . /weavedb
 ---> Using cache
 ---> 7367c98030d5
Successfully built 7367c98030d5
vagrant@vagrant-ubuntu-wily-64:~/minvol$ docker images foo/bar
REPOSITORY          TAG                 IMAGE ID            CREATED             SIZE
foo/bar             latest              7367c98030d5        9 minutes ago       28 B

Do we need to put anything in the docs for this now? I'm going to mention it when talking about persistence in the operational guide, does it need to go anywhere else? (make sure you rebase on recent master if you do because I restructured all the docs for wordepress)

That's a good point about the old image. I was following the Docker page on volumes where they note that using the same image doesn't cost any disk space because the layers are shared with the containers we do use, but that won't be true after an upgrade.

Might be irrelevant, but when we do weave reset, do we want to get rid of the data container?

Might be irrelevant, but when we do weave reset, do we want to get rid of the data container?

Already implemented!

I added a minimal image as suggested. Don't think you wanted to do ADD . /weavedb

Docs: I'll wait and see what you put in the operational guide.

LGTM, just maybe commits can be squashed.

Rebased/squashed. The two commits cover separate concerns.

@bboreham and I just had a discussion about how peers specified to weave launch will always be ignored after the first launch now we have decoupled the persistence - proposals to fix are

• Use the union of CLI peers and what is persisted
• Support a --replace argument to weave launch

@rade thoughts?

I'd like "weave launch x y z" be equivalent to "weave launch; weave connect x; weave connect y; weave connect z" as much as possible.

So I think we want the union.

We already have a "connect --replace" iirc, so adding a "launch --replace" seems logical.

See #2160 for union and --replace