fix!: remove deprecated environmentMatchGlobs and poolMatchGlobs (#8205)

sheremet-va · web-flow · commit be11d374ca5e · 2025-06-22T09:59:03.000+02:00
diff --git a/docs/config/index.md b/docs/config/index.md
@@ -593,101 +593,6 @@ jsdom environment exposes `jsdom` global variable equal to the current [JSDOM](h
 
 These options are passed down to `setup` method of current [`environment`](#environment). By default, you can configure only JSDOM options, if you are using it as your test environment.
 
-### environmentMatchGlobs
-
-- **Type:** `[string, EnvironmentName][]`
-- **Default:** `[]`
-
-::: danger DEPRECATED
-This API was deprecated in Vitest 3. Use [projects](/guide/projects) to define different configurations instead.
-
-```ts
-export default defineConfig({
-  test: {
-    environmentMatchGlobs: [ // [!code --]
-      ['./*.jsdom.test.ts', 'jsdom'], // [!code --]
-    ], // [!code --]
-    projects: [ // [!code ++]
-      { // [!code ++]
-        extends: true, // [!code ++]
-        test: { // [!code ++]
-          environment: 'jsdom', // [!code ++]
-        }, // [!code ++]
-      }, // [!code ++]
-    ], // [!code ++]
-  },
-})
-```
-:::
-
-Automatically assign environment based on globs. The first match will be used.
-
-For example:
-
-```ts
-import { defineConfig } from 'vitest/config'
-
-export default defineConfig({
-  test: {
-    environmentMatchGlobs: [
-      // all tests in tests/dom will run in jsdom
-      ['tests/dom/**', 'jsdom'],
-      // all tests in tests/ with .edge.test.ts will run in edge-runtime
-      ['**\/*.edge.test.ts', 'edge-runtime'],
-      // ...
-    ]
-  }
-})
-```
-
-### poolMatchGlobs {#poolmatchglobs}
-
-- **Type:** `[string, 'threads' | 'forks' | 'vmThreads' | 'vmForks' | 'typescript'][]`
-- **Default:** `[]`
-
-::: danger DEPRECATED
-This API was deprecated in Vitest 3. Use [projects](/guide/projects) to define different configurations instead:
-
-```ts
-export default defineConfig({
-  test: {
-    poolMatchGlobs: [ // [!code --]
-      ['./*.threads.test.ts', 'threads'], // [!code --]
-    ], // [!code --]
-    projects: [ // [!code ++]
-      { // [!code ++]
-        test: { // [!code ++]
-          extends: true, // [!code ++]
-          pool: 'threads', // [!code ++]
-        }, // [!code ++]
-      }, // [!code ++]
-    ], // [!code ++]
-  },
-})
-```
-:::
-
-Automatically assign pool in which tests will run based on globs. The first match will be used.
-
-For example:
-
-```ts
-import { defineConfig } from 'vitest/config'
-
-export default defineConfig({
-  test: {
-    poolMatchGlobs: [
-      // all tests in "worker-specific" directory will run inside a worker as if you enabled `--pool=threads` for them,
-      ['**/tests/worker-specific/**', 'threads'],
-      // run all tests in "browser" directory in an actual browser
-      ['**/tests/browser/**', 'browser'],
-      // all other tests will run based on "browser.enabled" and "threads" options, if you didn't specify other globs
-      // ...
-    ]
-  }
-})
-```
-
 ### update<NonProjectOption />
 
 - **Type:** `boolean`
diff --git a/docs/guide/environment.md b/docs/guide/environment.md
@@ -39,8 +39,6 @@ test('test', () => {
 })
 ```
 
-Or you can also set [`environmentMatchGlobs`](https://vitest.dev/config/#environmentmatchglobs) option specifying the environment based on the glob patterns.
-
 ## Custom Environment
 
 You can create your own package to extend Vitest environment. To do so, create package with the name `vitest-environment-${name}` or specify a path to a valid JS/TS file. That package should export an object with the shape of `Environment`:
diff --git a/docs/guide/migration.md b/docs/guide/migration.md
@@ -85,6 +85,13 @@ See also new guides:
 - [Including and excluding files from coverage report](/guide/coverage.html#including-and-excluding-files-from-coverage-report) for examples
 - [Profiling Test Performance | Code coverage](/guide/profiling-test-performance.html#code-coverage) for tips about debugging coverage generation
 
+### Deprecated APIs are Removed
+
+Vitest 4.0 removes some deprecated APIs, including:
+
+- `poolMatchGlobs` config option. Use [`projects`](/guide/projects) instead.
+- `environmentMatchGlobs` config option. Use [`projects`](/guide/projects) instead.
+
 ## Migrating to Vitest 3.0 {#vitest-3}
 
 ### Test Options as a Third Argument
diff --git a/packages/browser/src/node/plugin.ts b/packages/browser/src/node/plugin.ts
@@ -12,7 +12,7 @@ import { basename, dirname, extname, resolve } from 'pathe'
 import sirv from 'sirv'
 import * as vite from 'vite'
 import { coverageConfigDefaults } from 'vitest/config'
-import { getFilePoolName, resolveApiServerConfig, resolveFsAllow, distDir as vitestDist } from 'vitest/node'
+import { resolveApiServerConfig, resolveFsAllow, distDir as vitestDist } from 'vitest/node'
 import { distRoot } from './constants'
 import { createOrchestratorMiddleware } from './middlewares/orchestratorMiddleware'
 import { createTesterMiddleware } from './middlewares/testerMiddleware'
@@ -165,10 +165,7 @@ export default (parentServer: ParentBrowserProject, base = '/'): Plugin[] => {
         // this plugin can be used in different projects, but all of them
         // have the same `include` pattern, so it doesn't matter which project we use
         const project = parentServer.project
-        const { testFiles: allTestFiles } = await project.globTestFiles()
-        const browserTestFiles = allTestFiles.filter(
-          file => getFilePoolName(project, file) === 'browser',
-        )
+        const { testFiles: browserTestFiles } = await project.globTestFiles()
         const setupFiles = toArray(project.config.setupFiles)
 
         // replace env values - cannot be reassign at runtime
diff --git a/packages/vitest/src/node/cli/cli-config.ts b/packages/vitest/src/node/cli/cli-config.ts
@@ -849,7 +849,6 @@ export const cliOptionsConfig: VitestCLIOptions = {
   includeSource: null,
   alias: null,
   env: null,
-  environmentMatchGlobs: null,
   environmentOptions: null,
   unstubEnvs: null,
   related: null,
@@ -866,7 +865,6 @@ export const cliOptionsConfig: VitestCLIOptions = {
   chaiConfig: null,
   clearMocks: null,
   css: null,
-  poolMatchGlobs: null,
   deps: null,
   name: null,
   snapshotEnvironment: null,
diff --git a/packages/vitest/src/node/config/resolveConfig.ts b/packages/vitest/src/node/config/resolveConfig.ts
@@ -609,17 +609,6 @@ export function resolveConfig(
   if (!builtinPools.includes(resolved.pool as BuiltinPool)) {
     resolved.pool = resolvePath(resolved.pool, resolved.root)
   }
-  if (resolved.poolMatchGlobs) {
-    logger.deprecate('`poolMatchGlobs` is deprecated. Use `test.projects` to define different configurations instead.')
-  }
-  resolved.poolMatchGlobs = (resolved.poolMatchGlobs || []).map(
-    ([glob, pool]) => {
-      if (!builtinPools.includes(pool as BuiltinPool)) {
-        pool = resolvePath(pool, resolved.root)
-      }
-      return [glob, pool]
-    },
-  )
 
   if (mode === 'benchmark') {
     resolved.benchmark = {
@@ -792,13 +781,6 @@ export function resolveConfig(
     ...resolved.typecheck,
   }
 
-  if (resolved.environmentMatchGlobs) {
-    logger.deprecate('"environmentMatchGlobs" is deprecated. Use `test.projects` to define different configurations instead.')
-  }
-  resolved.environmentMatchGlobs = (resolved.environmentMatchGlobs || []).map(
-    i => [resolve(resolved.root, i[0]), i[1]],
-  )
-
   resolved.typecheck ??= {} as any
   resolved.typecheck.enabled ??= false
 
diff --git a/packages/vitest/src/node/pool.ts b/packages/vitest/src/node/pool.ts
@@ -4,7 +4,6 @@ import type { TestProject } from './project'
 import type { TestSpecification } from './spec'
 import type { BuiltinPool, Pool } from './types/pool-options'
 import { isatty } from 'node:tty'
-import pm from 'picomatch'
 import { version as viteVersion } from 'vite'
 import { isWindows } from '../utils/env'
 import { createForksPool } from './pools/forks'
@@ -66,17 +65,7 @@ function getDefaultPoolName(project: TestProject): Pool {
   return project.config.pool
 }
 
-export function getFilePoolName(project: TestProject, file: string): Pool {
-  for (const [glob, pool] of project.config.poolMatchGlobs) {
-    if ((pool as Pool) === 'browser') {
-      throw new Error(
-        'Since Vitest 0.31.0 "browser" pool is not supported in `poolMatchGlobs`. You can create a project to run some of your tests in browser in parallel. Read more: https://vitest.dev/guide/projects',
-      )
-    }
-    if (pm.isMatch(file, glob, { cwd: project.config.root })) {
-      return pool as Pool
-    }
-  }
+export function getFilePoolName(project: TestProject): Pool {
   return getDefaultPoolName(project)
 }
 
diff --git a/packages/vitest/src/node/project.ts b/packages/vitest/src/node/project.ts
@@ -157,7 +157,7 @@ export class TestProject {
     return new TestSpecification(
       this,
       moduleId,
-      pool || getFilePoolName(this, moduleId),
+      pool || getFilePoolName(this),
       locations,
     )
   }
diff --git a/packages/vitest/src/node/types/browser.ts b/packages/vitest/src/node/types/browser.ts
@@ -66,8 +66,6 @@ type UnsupportedProperties =
   | 'api'
   | 'deps'
   | 'testTransformMode'
-  | 'poolMatchGlobs'
-  | 'environmentMatchGlobs'
   | 'environment'
   | 'environmentOptions'
   | 'server'
diff --git a/packages/vitest/src/node/types/config.ts b/packages/vitest/src/node/types/config.ts
@@ -332,24 +332,6 @@ export interface InlineConfig {
    */
   environmentOptions?: EnvironmentOptions
 
-  /**
-   * Automatically assign environment based on globs. The first match will be used.
-   * This has effect only when running tests inside Node.js.
-   *
-   * Format: [glob, environment-name]
-   *
-   * @deprecated use [`projects`](https://vitest.dev/config/#projects) instead
-   * @default []
-   * @example [
-   *   // all tests in tests/dom will run in jsdom
-   *   ['tests/dom/**', 'jsdom'],
-   *   // all tests in tests/ with .edge.test.ts will run in edge-runtime
-   *   ['**\/*.edge.test.ts', 'edge-runtime'],
-   *   // ...
-   * ]
-   */
-  environmentMatchGlobs?: [string, VitestEnvironment][]
-
   /**
    * Run tests in an isolated environment. This option has no effect on vmThreads pool.
    *
@@ -390,22 +372,6 @@ export interface InlineConfig {
    */
   fileParallelism?: boolean
 
-  /**
-   * Automatically assign pool based on globs. The first match will be used.
-   *
-   * Format: [glob, pool-name]
-   *
-   * @deprecated use [`projects`](https://vitest.dev/config/#projects) instead
-   * @default []
-   * @example [
-   *   // all tests in "forks" directory will run using "poolOptions.forks" API
-   *   ['tests/forks/**', 'forks'],
-   *   // all other tests will run based on "poolOptions.threads" option, if you didn't specify other globs
-   *   // ...
-   * ]
-   */
-  poolMatchGlobs?: [string, Exclude<Pool, 'browser'>][]
-
   /**
    * Options for projects
    */
diff --git a/packages/vitest/src/utils/test-helpers.ts b/packages/vitest/src/utils/test-helpers.ts
@@ -40,17 +40,7 @@ export async function groupFilesByEnv(
 
       // 1. Check for control comments in the file
       let env = code.match(/@(?:vitest|jest)-environment\s+([\w-]+)\b/)?.[1]
-      // 2. Check for globals
-      if (!env) {
-        for (const [glob, target] of project.config.environmentMatchGlobs
-          || []) {
-          if (pm.isMatch(filepath, glob, { cwd: project.config.root })) {
-            env = target
-            break
-          }
-        }
-      }
-      // 3. Fallback to global env
+      // 2. Fallback to global env
       env ||= project.config.environment || 'node'
 
       const transformMode = getTransformMode(
diff --git a/test/config/test/pool-isolation.test.ts b/test/config/test/pool-isolation.test.ts
@@ -18,23 +18,6 @@ describe.each(['forks', 'threads'] as const)('%s', async (pool) => {
     expect(exitCode).toBe(0)
   })
 
-  test('is isolated + poolMatchGlobs', async () => {
-    const { stderr, exitCode } = await runVitest({
-      root: './fixtures/pool-isolation',
-      include: ['isolated.test.ts'],
-      pool,
-      poolMatchGlobs: [['**', pool]],
-      poolOptions: {
-        // Use default value on the tested pool and disable on the other one
-        [invertPool(pool)]: { isolate: false },
-      },
-      env: { TESTED_POOL: pool },
-    })
-
-    expect(stderr).toBe(deprecatedPoolMatchGlob())
-    expect(exitCode).toBe(0)
-  })
-
   test('is not isolated', async () => {
     const { stderr, exitCode } = await runVitest({
       root: './fixtures/pool-isolation',
@@ -49,28 +32,8 @@ describe.each(['forks', 'threads'] as const)('%s', async (pool) => {
     expect(stderr).toBe('')
     expect(exitCode).toBe(0)
   })
-
-  test('is not isolated + poolMatchGlobs', async () => {
-    const { stderr, exitCode } = await runVitest({
-      root: './fixtures/pool-isolation',
-      include: ['non-isolated.test.ts'],
-      pool: invertPool(pool),
-      poolMatchGlobs: [['**/**.test.ts', pool]],
-      poolOptions: {
-        [pool]: { isolate: false },
-      },
-      env: { TESTED_POOL: pool },
-    })
-
-    expect(stderr).toBe(deprecatedPoolMatchGlob())
-    expect(exitCode).toBe(0)
-  })
 })
 
 function invertPool(pool: 'threads' | 'forks') {
   return pool === 'threads' ? 'forks' : 'threads'
 }
-
-function deprecatedPoolMatchGlob() {
-  return ' DEPRECATED  `poolMatchGlobs` is deprecated. Use `test.projects` to define different configurations instead.\n'
-}
diff --git a/test/core/test/child-specific.child_process.test.ts b/test/core/test/child-specific.child_process.test.ts
@@ -1,11 +1,13 @@
 import { isMainThread, threadId } from 'node:worker_threads'
 import { expect, test } from 'vitest'
 
-test('has access to child_process API', () => {
+test('has access to child_process API', ({ task, skip }) => {
+  skip(task.file.pool !== 'child_process', 'Run only in child_process pool')
   expect(process.send).toBeDefined()
 })
 
-test('doesn\'t have access to threads API', () => {
+test('doesn\'t have access to threads API', ({ task, skip }) => {
+  skip(task.file.pool !== 'child_process', 'Run only in child_process pool')
   expect(isMainThread).toBe(true)
   expect(threadId).toBe(0)
 })
diff --git a/test/core/test/env-glob-dom/env-glob.overrides.spec.ts b/test/core/test/env-glob-dom/env-glob.overrides.spec.ts
diff --git a/test/core/test/env-glob-dom/env-glob.spec.ts b/test/core/test/env-glob-dom/env-glob.spec.ts
diff --git a/test/core/test/env-glob.dom.test.ts b/test/core/test/env-glob.dom.test.ts
diff --git a/test/core/test/threads-specific.threads.test.ts b/test/core/test/threads-specific.threads.test.ts
diff --git a/test/core/vite.config.ts b/test/core/vite.config.ts

Original file line number	Diff line number	Diff line change
`@@ -157,7 +157,7 @@ export class TestProject {`
`157`	`157`	`return new TestSpecification(`
`158`	`158`	`this,`
`159`	`159`	`moduleId,`
`160`		`- pool \|\| getFilePoolName(this, moduleId),`
	`160`	`+ pool \|\| getFilePoolName(this),`
`161`	`161`	`locations,`
`162`	`162`	`)`
`163`	`163`	`}`