Skip to content

Conversation

@qlrd
Copy link
Contributor

@qlrd qlrd commented Jan 26, 2025

What is this PR for?

This PR fixes issue #354

What is the purpose of this pull request?

  • Bug fix;
  • New feature;
  • Docs update;
  • Test;
  • Other: .

Which aspect of floresta its being addresed?

  • Blockchain;
  • Nodes communication;
  • User consumption;
  • Utreexo accumulator;
  • Other: .

Checklists

  • I've signed all my commits;
  • I ran just lint;
  • I ran cargo test;
  • I checked the integration tests;
  • I'm linking the issue being fixed by this PR (if any).

Description

The README.md and CONTRIBUTING.md need a little fix in some links. Both either point to wrong or invalid resources.

Notes to the reviewers

In the introductory section of README.md, the pre-built binaries link was pointing to version v0.4.0 and the current version is 0.7.0.

It would be better to have a dynamic pointing to releases using github's /releases/latest endpoint.

The maintainer PGP key link pointee to a invalid link (blog.dlsouzadot.lol/assets/pgp.asc give a 404 HTTP error).

This PR simple changes pgp.asc to gpg.asc in the refered link in both README.md and CONTRIBUTING.md.

qlrd added 2 commits January 26, 2025 09:48
was pointing to version `v0.4.0` and the current version is `0.7.0`.

It would be better to have a dynamic pointing to releases using
github's `/releases/latest` endpoint.
 dot lol at assets/pgp.asc give a 404 HTTP error).

This commit simple changes `pgp.asc` to `gpg.asc` in the refered link
in both README.md and CONTRIBUTING.md.
@Davidson-Souza Davidson-Souza merged commit 5f1b8ab into vinteumorg:master Jan 27, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants