Use fresh chainstates for each bencher iteration #492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In fact the benches were literally telling us exactly this, we were doing an expensive iteration and the rest of them were super fast in comparison. After the change (second picture), we see that iteration time is more consistent. |
15 tasks
Both our `accept_header` and `connect_block` methods have early return cases for when we already have the header or have validated the block. Hence the benches that used a single chainstate for all bencher iterations will use these early return cases. I have used the `iter_batched` method to set up the chainstate for every bencher iteration (excluded for the measurement), which makes them accurate now.
ba687d3 to
c79b682
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Which crates are being modified?
Description
Both our
accept_headerandconnect_blockmethods have early return cases for when we already have the header or have validated the block.Hence the benches that used a single chainstate for all bencher iterations will use these early return cases. I have used the
iter_batchedmethod to set up the chainstate for every bencher iteration (excluded for the measurement), which makes them accurate now.Notes to the reviewers
Also useful to avoid re-calling
connect_blockfor already validated blocks, which we expect to make invalid after #488