ht: Checks if PhantomJS is installed

SchumacherFM · vdobler · commit fd83b32cd552 · 2017-01-18T22:54:54.000+01:00
This prevents executing tests if phantomjs is not installed.
It checks the PATH environment variable and caches the result.
diff --git a/ht/phantomjs.go b/ht/phantomjs.go
@@ -821,3 +821,34 @@ func calibratePhantomjsOverhead() {
 
 	os.Remove(name)
 }
+
+// isPhantomJSInstalled has three states: 0 not checked, 1 not available,
+// 2 available
+var isPhantomJSInstalled int
+
+// IsPhantomJSInstalled returns true if PhantomJS has been installed. It caches
+// the result.
+func IsPhantomJSInstalled() bool {
+	if isPhantomJSInstalled > 0 {
+		return isPhantomJSInstalled == 2
+	}
+	if PhantomJSExecutable != "phantomjs" {
+		return true
+	}
+
+	paths := strings.Split(os.Getenv("PATH"), string(os.PathListSeparator))
+	isPhantomJSInstalled = 1
+	for _, path := range paths {
+		p := fmt.Sprintf("%s%s%s", path, string(os.PathSeparator), PhantomJSExecutable)
+		if fileExists(p) {
+			isPhantomJSInstalled = 2
+			break
+		}
+	}
+	return isPhantomJSInstalled == 2
+}
+
+func fileExists(path string) bool {
+	fi, err := os.Stat(path)
+	return !os.IsNotExist(err) && fi.Size() > 0
+}
diff --git a/ht/phantomjs_test.go b/ht/phantomjs_test.go
@@ -325,6 +325,10 @@ var passingScreenshotTests = []*Test{
 }
 
 func TestScreenshotPass(t *testing.T) {
+	if !IsPhantomJSInstalled() {
+		t.Skip("PhantomJS is not installed")
+	}
+
 	ts := httptest.NewServer(http.HandlerFunc(screenshotHandler))
 	defer ts.Close()
 
@@ -406,6 +410,10 @@ var failingScreenshotTests = []*Test{
 }
 
 func TestScreenshotFail(t *testing.T) {
+	if !IsPhantomJSInstalled() {
+		t.Skip("PhantomJS is not installed")
+	}
+
 	ts := httptest.NewServer(http.HandlerFunc(screenshotHandler))
 	defer ts.Close()
 
@@ -484,6 +492,10 @@ var passingRenderedHTMLTests = []*Test{
 }
 
 func TestRenderedHTMLPassing(t *testing.T) {
+	if !IsPhantomJSInstalled() {
+		t.Skip("PhantomJS is not installed")
+	}
+
 	ts := httptest.NewServer(http.HandlerFunc(screenshotHandler))
 	defer ts.Close()
 
@@ -533,6 +545,10 @@ var passingRenderingTimeTests = []*Test{
 }
 
 func TestRenderingTime(t *testing.T) {
+	if !IsPhantomJSInstalled() {
+		t.Skip("PhantomJS is not installed")
+	}
+
 	ts := httptest.NewServer(http.HandlerFunc(screenshotHandler))
 	defer ts.Close()
 
@@ -579,6 +595,10 @@ var passingRenderingTimeTests2 = []*Test{
 }
 
 func TestRenderingTime2(t *testing.T) {
+	if !IsPhantomJSInstalled() {
+		t.Skip("PhantomJS is not installed")
+	}
+
 	ts := httptest.NewServer(http.HandlerFunc(animationHandler))
 	defer ts.Close()
 
@@ -669,6 +689,10 @@ func animationHandler(w http.ResponseWriter, r *http.Request) {
 }
 
 func TestFancyScreenshotPass(t *testing.T) {
+	if !IsPhantomJSInstalled() {
+		t.Skip("PhantomJS is not installed")
+	}
+
 	ts := httptest.NewServer(http.HandlerFunc(animationHandler))
 	defer ts.Close()
 
@@ -699,6 +723,10 @@ func TestFancyScreenshotPass(t *testing.T) {
 }
 
 func TestFancyScreenshotFail(t *testing.T) {
+	if !IsPhantomJSInstalled() {
+		t.Skip("PhantomJS is not installed")
+	}
+
 	ts := httptest.NewServer(http.HandlerFunc(animationHandler))
 	defer ts.Close()
 
