Skip to content

Fix Islamic holidays tests #2849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2025
Merged

Fix Islamic holidays tests #2849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/countries/test_afghanistan.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ def test_international_workers_day(self):
def test_soviet_victory_day(self):
name = "روز پیروزی شوروی"
self.assertHolidayName(name, (f"{year}-05-09" for year in range(1978, 1989)))
self.assertNoHolidayName(name, range(1919, 1978), (1989, 2050))
self.assertNoHolidayName(name, range(1919, 1978), range(1989, 2050))

def test_islamic_emirat_victory_day(self):
name = "روز پیروزی امارت اسلامی"
Expand All @@ -96,7 +96,7 @@ def test_independence_day(self):
def test_martyrs_day(self):
name = "روز شهیدان"
self.assertHolidayName(name, (f"{year}-09-09" for year in range(2012, 2021)))
self.assertNoHolidayName(name, range(1919, 2012), (2021, 2050))
self.assertNoHolidayName(name, range(1919, 2012), range(2021, 2050))

def test_ashura(self):
name = "عاشورا"
Expand Down
8 changes: 5 additions & 3 deletions tests/countries/test_azerbaijan.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,9 @@
class TestAzerbaijan(CommonCountryTests, WorkingDayTests, TestCase):
@classmethod
def setUpClass(cls):
super().setUpClass(Azerbaijan, years=range(1990, 2050))
years = range(1990, 2050)
super().setUpClass(Azerbaijan, years=years)
cls.no_estimated_holidays = Azerbaijan(years=years, islamic_show_estimated=False)

def test_country_aliases(self):
self.assertAliases(Azerbaijan, AZ, AZE)
Expand Down Expand Up @@ -246,7 +248,7 @@ def test_eid_al_fitr(self):
"2023-04-22",
)
self.assertNoHolidayName(name, "2004-11-15", "2005-11-04")
self.assertNoHolidayName(name, range(1990, 1993))
self.assertNoHolidayName(name, self.no_estimated_holidays, range(1990, 1993))

def test_eid_al_adha(self):
name = "Qurban bayrami"
Expand All @@ -264,7 +266,7 @@ def test_eid_al_adha(self):
"2023-06-29",
)
self.assertNoHolidayName(name, "2004-02-02", "2005-01-23", "2006-01-11")
self.assertNoHolidayName(name, range(1990, 1993))
self.assertNoHolidayName(name, self.no_estimated_holidays, range(1990, 1993))

def test_observed_days(self):
observed_holidays = (
Expand Down
14 changes: 6 additions & 8 deletions tests/countries/test_kazakhstan.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,9 @@
class TestKazakhstan(CommonCountryTests, WorkingDayTests, TestCase):
@classmethod
def setUpClass(cls):
super().setUpClass(Kazakhstan, years=range(1991, 2050))
years = range(1991, 2050)
super().setUpClass(Kazakhstan, years=years, years_non_observed=years)
cls.no_estimated_holidays = Kazakhstan(years=years, islamic_show_estimated=False)

def test_country_aliases(self):
self.assertAliases(Kazakhstan, KZ, KAZ)
Expand Down Expand Up @@ -168,9 +170,7 @@ def test_nauryz(self):
self.assertHolidayName(name, f"{year}-03-21", f"{year}-03-22", f"{year}-03-23")
self.assertNoHolidayName(name, range(1991, 2002))
for year in set(range(2002, 2010)) - {2005, 2007}:
self.assertNoNonObservedHoliday(
Kazakhstan(observed=False, years=year), f"{year}-03-21", f"{year}-03-23"
)
self.assertNoNonObservedHoliday(f"{year}-03-21", f"{year}-03-23")

def test_solidarity_day(self):
self.assertHolidayName(
Expand Down Expand Up @@ -218,10 +218,7 @@ def test_independence_day(self):
self.assertHolidayName(name, (f"{year}-12-16" for year in range(1991, 2050)))
self.assertHolidayName(name, (f"{year}-12-17" for year in range(2002, 2022)))
self.assertNoHoliday(f"{year}-12-17" for year in range(1991, 2002))
self.assertNoNonObservedHoliday(
Kazakhstan(observed=False, years=range(2022, 2050)),
(f"{year}-12-17" for year in range(2022, 2050)),
)
self.assertNoNonObservedHoliday(f"{year}-12-17" for year in range(2022, 2050))

def test_kurban_ait(self):
name = "Құрбан айт"
Expand All @@ -248,6 +245,7 @@ def test_kurban_ait(self):
"2024-06-16",
"2025-06-06",
)
self.assertNoHolidayName(name, self.no_estimated_holidays, range(1991, 2006))

def test_observed(self):
observed_holidays = (
Expand Down
Loading