Skip to content

Add Ghana holidays #1639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Jan 26, 2024
Merged

Add Ghana holidays #1639

merged 16 commits into from
Jan 26, 2024

Conversation

@JerryAgbesi
Copy link
Contributor

Proposed change

Adds support for official public holidays observed in Ghana

closes #1191

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

@coveralls
Copy link

coveralls commented Jan 11, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7671158053

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 40 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 7635551030: 0.0%
Covered Lines: 10426
Relevant Lines: 10426
💛 - Coveralls

arkid15r
arkid15r reviewed Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JerryAgbesi thank you for implementing a new country support. The first one in 2024!

Please take a look at some improvement suggestions when you have a chance:

KJhellico
KJhellico reviewed Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JerryAgbesi, new countries are always welcomed! 👍 Please take a look at a few suggestions.

@JerryAgbesi
Copy link
Contributor Author

Alright great, I'll add in the changes. Cheers 🥂

arkid15r
arkid15r reviewed Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @JerryAgbesi great work on the PR!

Please take a look at another round of my (mostly consistency enforcing) comments.
It seems it's good to go to beta after that 👍

@JerryAgbesi JerryAgbesi requested a review from arkid15r January 24, 2024 20:17
KJhellico
KJhellico reviewed Jan 24, 2024
View reviewed changes
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

arkid15r
arkid15r reviewed Jan 26, 2024
View reviewed changes
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KJhellico I hope we can finally accept it?

@arkid15r arkid15r enabled auto-merge January 26, 2024 17:21
@KJhellico KJhellico changed the title Add Ghana public holidays Add Ghana holidays Jan 26, 2024
KJhellico
KJhellico approved these changes Jan 26, 2024
View reviewed changes
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arkid15r arkid15r added this pull request to the merge queue Jan 26, 2024
Merged via the queue into vacanza:beta with commit 08e3dc7 Jan 26, 2024
@KJhellico KJhellico mentioned this pull request Jan 26, 2024
Closed
@KJhellico KJhellico mentioned this pull request Feb 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arkid15r arkid15r arkid15r left review comments

@KJhellico KJhellico KJhellico approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Ghana holidays

4 participants

@JerryAgbesi @coveralls @arkid15r @KJhellico