Skip to content

Conversation

@gunnsth
Copy link
Contributor

@gunnsth gunnsth commented Apr 18, 2020

Refactor the existing functionality to enable loading from stream rather than just file. More flexible.

Clarified documentation a bit and added a note regarding composite fonts to the simple TTF font loading functions NewPdfFontFromTTF.


This change is Reviewable

@codecov
Copy link

codecov bot commented Apr 18, 2020

Codecov Report

Merging #319 into development will increase coverage by 4.08%.
The diff coverage is 55.55%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #319      +/-   ##
===============================================
+ Coverage        52.28%   56.37%   +4.08%     
===============================================
  Files              235      235              
  Lines            45436    45443       +7     
===============================================
+ Hits             23758    25617    +1859     
+ Misses           18611    16524    -2087     
- Partials          3067     3302     +235     
Impacted Files Coverage Δ
model/font_simple.go 74.29% <ø> (+5.98%) ⬆️
model/font_composite.go 62.91% <55.55%> (+7.63%) ⬆️
internal/jbig2/document/segments/text-region.go 41.05% <0.00%> (+0.22%) ⬆️
...ernal/jbig2/document/segments/symbol-dictionary.go 38.49% <0.00%> (+0.23%) ⬆️
internal/jbig2/bitmap/bitmap.go 76.76% <0.00%> (+0.28%) ⬆️
model/writer.go 75.67% <0.00%> (+0.42%) ⬆️
internal/jbig2/document/segments/generic-region.go 47.75% <0.00%> (+1.18%) ⬆️
fdf/parser.go 40.27% <0.00%> (+1.38%) ⬆️
internal/jbig2/document/segments/kind.go 11.59% <0.00%> (+1.44%) ⬆️
model/reader.go 46.41% <0.00%> (+1.67%) ⬆️
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11f3a6e...fa5f135. Read the comment docs.

@gunnsth gunnsth requested a review from ahall April 18, 2020 13:26
@ahall ahall merged commit 8a6826a into unidoc:development Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants