Skip to content

Conversation

@peterwilliams97
Copy link
Contributor

@peterwilliams97 peterwilliams97 commented Mar 19, 2020

Fix for #279
Replaces #280 which was based on the wrong branch


This change is Reviewable

@codecov
Copy link

codecov bot commented Mar 19, 2020

Codecov Report

Merging #281 into development will increase coverage by 4.76%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #281      +/-   ##
===============================================
+ Coverage        51.85%   56.62%   +4.76%     
===============================================
  Files              202      202              
  Lines            38509    38512       +3     
===============================================
+ Hits             19970    21807    +1837     
+ Misses           15990    13933    -2057     
- Partials          2549     2772     +223     
Impacted Files Coverage Δ
core/encoding.go 50.65% <0.00%> (+12.03%) ⬆️
internal/jbig2/segments/text-region.go 46.85% <0.00%> (+0.26%) ⬆️
internal/jbig2/segments/symbol-dictionary.go 50.54% <0.00%> (+0.30%) ⬆️
model/writer.go 75.67% <0.00%> (+0.42%) ⬆️
internal/jbig2/segments/generic-region.go 47.66% <0.00%> (+1.35%) ⬆️
fdf/parser.go 40.27% <0.00%> (+1.38%) ⬆️
internal/jbig2/page.go 31.21% <0.00%> (+1.46%) ⬆️
model/reader.go 46.41% <0.00%> (+1.67%) ⬆️
contentstream/contentstream.go 76.36% <0.00%> (+1.81%) ⬆️
core/primitives.go 78.75% <0.00%> (+2.40%) ⬆️
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5987255...7a04227. Read the comment docs.

Copy link
Contributor

@gunnsth gunnsth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gunnsth gunnsth merged commit 38b564c into unidoc:development Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants