fix: ignore .WithStack and .WithMessagef from github.com/pkg/errors (#15)

r2k1 · web-flow · commit 56ecd1e91783 · 2021-06-15T22:27:51.000+02:00
diff --git a/README.md b/README.md
@@ -35,6 +35,8 @@ ignoreSigs:
 - .Wrap(
 - .Wrapf(
 - .WithMessage(
+- .WithMessagef(
+- .WithStack(
 ```
 
 ## Usage
diff --git a/wrapcheck/testdata/ignore_pkg_errors/main.go b/wrapcheck/testdata/ignore_pkg_errors/main.go
@@ -24,5 +24,13 @@ func do() error {
 		return errors.WithMessage(err, "uh oh")
 	}
 
-	return nil
+	if err != nil {
+		return errors.WithMessagef(err, "uh %s", "oh")
+	}
+
+	if err != nil {
+		return errors.WithStack(err)
+	}
+
+	return errors.New("uh oh")
 }
diff --git a/wrapcheck/wrapcheck.go b/wrapcheck/wrapcheck.go
@@ -16,6 +16,8 @@ var DefaultIgnoreSigs = []string{
 	".Wrap(",
 	".Wrapf(",
 	".WithMessage(",
+	".WithMessagef(",
+	".WithStack(",
 }
 
 // WrapcheckConfig is the set of configuration values which configure the

Original file line number	Diff line number	Diff line change
`@@ -24,5 +24,13 @@ func do() error {`
`24`	`24`	`return errors.WithMessage(err, "uh oh")`
`25`	`25`	`}`
`26`	`26`
`27`		`- return nil`
	`27`	`+ if err != nil {`
	`28`	`+ return errors.WithMessagef(err, "uh %s", "oh")`
	`29`	`+ }`
	`30`	`+`
	`31`	`+ if err != nil {`
	`32`	`+ return errors.WithStack(err)`
	`33`	`+ }`
	`34`	`+`
	`35`	`+ return errors.New("uh oh")`
`28`	`36`	`}`
Original file line number	Diff line number	Diff line change
`@@ -16,6 +16,8 @@ var DefaultIgnoreSigs = []string{`
`16`	`16`	`".Wrap(",`
`17`	`17`	`".Wrapf(",`
`18`	`18`	`".WithMessage(",`
	`19`	`+ ".WithMessagef(",`
	`20`	`+ ".WithStack(",`
`19`	`21`	`}`
`20`	`22`
`21`	`23`	`// WrapcheckConfig is the set of configuration values which configure the`