Avoid autoscrolling anchored URLs (vercel#474)

jxodwyer · nkzawa · commit 31feced24ac1 · 2016-12-22T17:15:49.000+09:00
* force scroll to false if # is found in url

* only overwrite scroll if scroll=true is not passed in

* clean up logic around setting scroll var
diff --git a/lib/link.js b/lib/link.js
@@ -14,7 +14,7 @@ export default class Link extends Component {
       return
     }
 
-    const { href, scroll, as } = this.props
+    const { href, as } = this.props
 
     if (!isLocal(href)) {
       // ignore click if it's outside our scope
@@ -26,6 +26,12 @@ export default class Link extends Component {
     const route = as ? href : null
     const url = as || href
 
+    //  avoid scroll for urls with anchor refs
+    let { scroll } = this.props
+    if (scroll == null) {
+      scroll = url.indexOf('#') < 0
+    }
+
     // straight up redirect
     Router.push(route, url)
       .then((success) => {
