For #460: Login screen #539
Conversation
|
Job #539 is now in scope, role is |
|
This pull request #539 is assigned to @amihaiemil/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @emilianodellacasa/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be a monetary reward for this job |
Codecov Report
@@ Coverage Diff @@
## master #539 +/- ##
=======================================
Coverage 90.34% 90.34%
=======================================
Files 55 55
Lines 1025 1025
Branches 57 57
=======================================
Hits 926 926
Misses 79 79
Partials 20 20Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #539 +/- ##
=======================================
Coverage 90.34% 90.34%
=======================================
Files 55 55
Lines 1025 1025
Branches 57 57
=======================================
Hits 926 926
Misses 79 79
Partials 20 20Continue to review full report at Codecov.
|
| {% block content %} | ||
| <!doctype html> | ||
| <title>{% block title %}{% endblock %} - Timlessis</title> | ||
| <link rel="stylesheet" href="{{ url_for('static', filename='login.css') }}"> |
There was a problem hiding this comment.
@paulodamaso why does the href have to be dynamic? Can't we just specify the path to the file?
There was a problem hiding this comment.
@amihaiemil Again, I'm following base.html
| @todo #460:30min Change the style of login page. Make the image for the | ||
| login page like shown in UX documentation, then apply the image to the | ||
| background of login page so it becomes equals to the image below | ||
| https://drive.google.com/uc?export=view&id=1oh8cLv-vHTCBmb0RDkHQiyMythC4_M6o |
There was a problem hiding this comment.
@paulodamaso wording in this puzzle is quite strange and has a few grammar mistakes. How about: "Change the style of the login page. Create the image specified in UX documentation, then apply oit as background. UX mock: [google docs link"
| } | ||
| .container { | ||
| padding: 16px; | ||
| } No newline at end of file |
There was a problem hiding this comment.
@paulodamaso why do we have the login.css both under /static and under /src?
There was a problem hiding this comment.
@amihaiemil I did it just like thew other css'
| transition: .6s; | ||
| } | ||
| .container { | ||
| padding: 16px; |
There was a problem hiding this comment.
@paulodamaso working with hardcoded pixels is rather strange, it means the design is not really responsive, but just happens to look good because the screen allows it.
But I see you did it everywhere. Can you leave a puzzle so someone who really knows CSS makes it responsive with CSS 3 screen width meta tags?
|
Please see also #523 |
| } | ||
| .container { | ||
| padding: 16px; | ||
| } No newline at end of file |
There was a problem hiding this comment.
@amihaiemil I did it just like thew other css'
| {% block content %} | ||
| <!doctype html> | ||
| <title>{% block title %}{% endblock %} - Timlessis</title> | ||
| <link rel="stylesheet" href="{{ url_for('static', filename='login.css') }}"> |
There was a problem hiding this comment.
@amihaiemil Again, I'm following base.html
|
@rultor good to merge |
@amihaiemil Thanks for your request. @emilianodellacasa Please confirm this. |
|
@amihaiemil/z this job was assigned to you 23days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please. |
|
@0crat refuse |
|
@zverovich/z I see that you unassigned this issue; the order is still assigned to @amihaiemil/z though; to cancel the order use |
|
@zverovich The user @amihaiemil/z resigned from #539, please stop working. Reason for job resignation: Order was cancelled |
For #460: Login screen change: