KEYCLOAK-18406 SAMLServletAdapterTest failures

mabartos · pdrozd · commit 333d279d7aeb · 2021-06-17T11:30:39.000+02:00
diff --git a/testsuite/integration-arquillian/tests/base/src/test/java/org/keycloak/testsuite/adapter/servlet/SAMLServletAdapterTest.java b/testsuite/integration-arquillian/tests/base/src/test/java/org/keycloak/testsuite/adapter/servlet/SAMLServletAdapterTest.java
@@ -109,6 +109,7 @@
 import org.keycloak.admin.client.resource.UserResource;
 import org.keycloak.common.util.Base64;
 import org.keycloak.common.util.KeyUtils;
+import org.keycloak.common.util.MultivaluedHashMap;
 import org.keycloak.common.util.PemUtils;
 import org.keycloak.dom.saml.v2.metadata.EntityDescriptorType;
 import org.keycloak.dom.saml.v2.protocol.AuthnRequestType;
@@ -493,6 +494,7 @@ private void assertFailedLogin(AbstractPage page, UserRepresentation user, Login
 
     private void assertSuccessfulLogin(AbstractPage page, UserRepresentation user, Login loginPage, String expectedString) {
         page.navigateTo();
+        waitForPageToLoad();
         assertCurrentUrlStartsWith(loginPage);
         loginPage.form().login(user);
         waitUntilElement(By.xpath("//body")).text().contains(expectedString);
@@ -662,7 +664,7 @@ private PublicKey createKeys(String priority) throws Exception {
         rep.setProviderId(ImportedRsaKeyProviderFactory.ID);
         rep.setProviderType(KeyProvider.class.getName());
 
-        org.keycloak.common.util.MultivaluedHashMap config = new org.keycloak.common.util.MultivaluedHashMap();
+        MultivaluedHashMap<String, String> config = new MultivaluedHashMap<>();
         config.addFirst("priority", priority);
         config.addFirst(Attributes.PRIVATE_KEY_KEY, NEW_KEY_PRIVATE_KEY_PEM);
         rep.setConfig(config);
@@ -683,6 +685,10 @@ private void dropKeys(String priority) {
     }
 
     private void testRotatedKeysPropagated(SAMLServlet servletPage, Login loginPage) throws Exception {
+        testRotatedKeysPropagated(servletPage, loginPage, true);
+    }
+
+    private void testRotatedKeysPropagated(SAMLServlet servletPage, Login loginPage, boolean shouldLogout) throws Exception {
         boolean keyDropped = false;
         try {
             log.info("Creating new key");
@@ -693,9 +699,12 @@ private void testRotatedKeysPropagated(SAMLServlet servletPage, Login loginPage)
             keyDropped = true;
             testSuccessfulAndUnauthorizedLogin(servletPage, loginPage);
         } finally {
-            if (! keyDropped) {
+            if (!keyDropped) {
                 dropKeys("1000");
             }
+            if (shouldLogout) {
+                servletPage.logout();
+            }
         }
     }
 
