DT-2854-5-dark-mode-menu #2754
Merged
DT-2854-5-dark-mode-menu #2754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
andrewzamojc
commented
Jun 2, 2025
| {#if open} | ||
| <div class="flex h-full flex-col justify-start gap-6 overflow-auto px-4 py-8"> | ||
| <TimezoneSelect position="left" /> | ||
| <TimezoneSelect position="left" size="sm" /> |
There was a problem hiding this comment.
Annotation: requested by @bilal-karim to match other menu item sizes
andrewzamojc
commented
Jun 2, 2025
| }); | ||
|
|
||
| test('user can toggle dark mode between on, off, and system default', async ({ | ||
| test('user can select System Default option via dropdown menu', async ({ |
There was a problem hiding this comment.
Annotation: Thanks AI for updating the tests for.
rossnelson
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
This PR updates the dark mode 3-state toggle button, to be a dropdown menu. This is based on feedback from @rossnelson during team testing, and ok'ed by @bilal-karim from design. This is intended to simplify and clarify the interaction for the user, and be more like other websites with dark mode options.
Screenshots (if applicable) 📸
Design Considerations 🎨
I got the UX go-ahead from @bilal-karim to convert 3-state dark mode toggle to a dropdown menu. Bilal also requested the size change in the bottom nav usage of it.
@bilal-karim dropdown alignment seems slightly off in the bottom nav menu, this is existing. Probably easy to fix but that can be another task.
Testing 🧪
Tested manually locally.
Updated integration tests for both.
Will test in cloud-ui before release.
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?