fix: site replication of bucket deletion sync (minio#352)

poornas · harshavardhana · commit 4df7a3aa8fa5 · 2025-02-04T00:36:03.000-08:00
Bucket deletion timestamp was not being passed back
in GetBucketInfo, which is needed to decide on the bucket
creation/deletion
diff --git a/cmd/peer-rest-server.go b/cmd/peer-rest-server.go
@@ -1308,6 +1308,7 @@ func (s *peerRESTServer) HeadBucketHandler(mss *grid.MSS) (info *VolInfo, nerr *
 	return &VolInfo{
 		Name:    bucketInfo.Name,
 		Created: bucketInfo.Created,
+		Deleted: bucketInfo.Deleted, // needed for site replication
 	}, nil
 }
 
diff --git a/cmd/peer-s3-client.go b/cmd/peer-s3-client.go
@@ -393,6 +393,7 @@ func (client *remotePeerS3Client) GetBucketInfo(ctx context.Context, bucket stri
 	return BucketInfo{
 		Name:    volInfo.Name,
 		Created: volInfo.Created,
+		Deleted: volInfo.Deleted,
 	}, nil
 }
 
diff --git a/cmd/storage-datatypes.go b/cmd/storage-datatypes.go
@@ -111,6 +111,9 @@ type VolInfo struct {
 
 	// total VolInfo counts
 	count int
+
+	// Date and time when the volume was deleted, if Deleted
+	Deleted time.Time
 }
 
 // FilesInfo represent a list of files, additionally
diff --git a/cmd/storage-datatypes_gen.go b/cmd/storage-datatypes_gen.go

Original file line number	Diff line number	Diff line change
`@@ -1308,6 +1308,7 @@ func (s peerRESTServer) HeadBucketHandler(mss grid.MSS) (info VolInfo, nerr `
`1308`	`1308`	`return &VolInfo{`
`1309`	`1309`	`Name: bucketInfo.Name,`
`1310`	`1310`	`Created: bucketInfo.Created,`
	`1311`	`+ Deleted: bucketInfo.Deleted, // needed for site replication`
`1311`	`1312`	`}, nil`
`1312`	`1313`	`}`
`1313`	`1314`
Original file line number	Diff line number	Diff line change
`@@ -393,6 +393,7 @@ func (client *remotePeerS3Client) GetBucketInfo(ctx context.Context, bucket stri`
`393`	`393`	`return BucketInfo{`
`394`	`394`	`Name: volInfo.Name,`
`395`	`395`	`Created: volInfo.Created,`
	`396`	`+ Deleted: volInfo.Deleted,`
`396`	`397`	`}, nil`
`397`	`398`	`}`
`398`	`399`
Original file line number	Diff line number	Diff line change
`@@ -111,6 +111,9 @@ type VolInfo struct {`
`111`	`111`
`112`	`112`	`// total VolInfo counts`
`113`	`113`	`count int`
	`114`	`+`
	`115`	`+ // Date and time when the volume was deleted, if Deleted`
	`116`	`+ Deleted time.Time`
`114`	`117`	`}`
`115`	`118`
`116`	`119`	`// FilesInfo represent a list of files, additionally`