Skip to content

GH-388: Fix CMS test issue caused by roundtripping depth->delta->depth #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 11, 2015
Merged

GH-388: Fix CMS test issue caused by roundtripping depth->delta->depth #395

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion algebird-test/src/test/scala/com/twitter/algebird/CountMinSketchTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -572,7 +572,7 @@ class CMSFunctionsSpec extends PropSpec with PropertyChecks with Matchers {
// For all i > 709 this test break because of precision limits: For all i > 709 will return 0.0, which is not the
// mathematically correct value but rather the asymptote of delta.
val maxI = 709
forAll(Gen.choose(0, maxI)) { (i: Int) =>
forAll((Gen.choose(1, maxI), "depth")) { (i: Int) =>
CMSFunctions.depth(CMSFunctions.delta(i)) should be(i)
}
}
Expand Down