Add scala 2.13 support #719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regadas
commented
Oct 9, 2019
|
I guess we can cut off 2.10. If you are that far behind you probably don’t need the latest version of algebird. |
3580a41 to
f1702e6
Compare
Codecov Report
@@ Coverage Diff @@
## develop #719 +/- ##
===========================================
+ Coverage 89.24% 89.35% +0.11%
===========================================
Files 114 114
Lines 8965 8955 -10
Branches 325 330 +5
===========================================
+ Hits 8001 8002 +1
+ Misses 964 953 -11
Continue to review full report at Codecov.
|
johnynek
reviewed
Oct 11, 2019
johnynek
reviewed
Oct 11, 2019
algebird-core/src/main/scala/com/twitter/algebird/SketchMap.scala
Outdated
Show resolved
Hide resolved
sritchie
reviewed
Oct 11, 2019
sritchie
reviewed
Oct 11, 2019
johnynek
reviewed
Oct 16, 2019
algebird-core/src/main/scala/com/twitter/algebird/HyperLogLogSeries.scala
Outdated
Show resolved
Hide resolved
algebird-core/src/main/scala/com/twitter/algebird/MapAlgebra.scala
Outdated
Show resolved
Hide resolved
algebird-core/src/main/scala/com/twitter/algebird/MapAlgebra.scala
Outdated
Show resolved
Hide resolved
algebird-core/src/main/scala/com/twitter/algebird/MapAlgebra.scala
Outdated
Show resolved
Hide resolved
algebird-core/src/main/scala/com/twitter/algebird/VectorSpace.scala
Outdated
Show resolved
Hide resolved
algebird-core/src/main/scala/com/twitter/algebird/macros/Cuber.scala
Outdated
Show resolved
Hide resolved
algebird-core/src/main/scala/com/twitter/algebird/package.scala
Outdated
Show resolved
Hide resolved
johnynek
reviewed
Oct 21, 2019
algebird-core/src/main/scala/com/twitter/algebird/HyperLogLog.scala
Outdated
Show resolved
Hide resolved
|
@johnynek well, I believe MiMa is working properly; we are using the latest MiMa and it's a bit more "picky"; I think that if we accidentally broke compatibility MiMa would be complaining. note: we are only running MiMa for 2.11 and 2.12. We can add for 2.13 once we release; |
johnynek
approved these changes
Oct 21, 2019
Closed
|
@johnynek Thanks for the review! 👍 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial take; Currently only targeting
algebird-coreandalgebird-test.There are some caveats to this:
I don't think we will be able to keep binary compatibilityalgebraandscala-collection-compatdon't publish for 2.10; I can backport some of the things inscala-collection-compatbut we would need to use a different version ofalgebrafor 2.10 which is not idealNOTE: MiMa is temporarily disabled