add Semigroup.maybePlus #544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
build.sbt
Outdated
| "-unchecked", | ||
| "-deprecation", | ||
| "-optimize", | ||
| "-Xlint:-adapted-args", |
There was a problem hiding this comment.
scala -Xlint:help says that adapter-args is for "Warn if an argument list is modified to match the receiver." Is that to warn on implicit conversions?
Collaborator
Author
There was a problem hiding this comment.
it is Right(1, 2) which is adapted to be Right((1, 2)) because Right(t: T) takes one arg. This code is littered with that and it makes warnings totally overwhelm the errors (so I couldn't even find the errors).
It does not work on 2.10, so I'll roll that back, but we really need to clean this up.
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this comes up often, and we see it in user code quite a bit.