-
Notifications
You must be signed in to change notification settings - Fork 4k
Description
Context
I'm inlining SVG images to be able to use Material for MkDocs' CSS variables for more consistent image styles with the rest of the page.
Slightly off topic but just for completeness: Unlike in the below reproduction (as I want to keep it minimal), I actually wrap the inline SVG in
<div>
<template shadowrootmode="open">
<svg ...>
...
</svg>
</template>
</div>to avoid leakage of the CSS definitions into the document and potentially conflict with other inline SVGs' CSS definitions.
Bug description
The blog readtime plugin extracts any text data from the generated HTML page content including, e.g., CSS definitions in inline SVG images. This leads to a bad estimate of the read time, especially when, e.g., there are many CSS definitions (i.e. much "text").
A fix might involve skipping some tags such as <svg>, <style>, and <script> when gathering text data. I'd be happy to contribute a fix if you agree with the bug report and when we've converged on a solution proposal.
Related links
Reproduction
9.5.29-blog-readtime-inline-svg.zip
I've edited venv/lib/python3.12/site-packages/material/plugins/blog/readtime/__init__.py to demonstrate the current behavior of the HTML parser:
# Extract words from text and compute readtime in seconds
+ print("DEBUG: ", parser.text)
words = len(re.split(r"\W+", "".join(parser.text)))
seconds = ceil(words / words_per_minute * 60)Steps to reproduce
-
Unzip the reproduction.
-
Run
mkdocs serve. -
Observe the line
DEBUG: ['Readtime includes inline SVG text', '\n', '\n ', '\n ', '\n ', '\n <![CDATA[\n .fill-red {\n fill: red;\n }\n ]]>\n ', '\n ', '\n ', '\n ', '\n ', 'Red SVG rectangle', '\n']in the terminal which shows the list of text data extracted by the HTML parser of the readtime plugin.
Browser
No response
Before submitting
- I have read and followed the bug reporting guidelines.
- I have attached links to the documentation, and possibly related issues and discussions.
- I assure that I have removed all customizations before submitting this bug report.
- I have attached a .zip file with a minimal reproduction using the built-in info plugin.