Skip to content
This repository was archived by the owner on Jun 27, 2019. It is now read-only.
This repository was archived by the owner on Jun 27, 2019. It is now read-only.

sol-fbp-runner has misleading error message and doesn't accept unexpected node metadata #377

@davidmaxwaterman

Description

@davidmaxwaterman
Confusing error message.

FBP files that have nodes containing unexpected metadata cause the Soletta fbp runner to fail with a misleading error message. For example, nodes contain metadata defining a label :

node9(constant/string:label=node9) OUT -> IN node10(console:label=node10)

Causes the runner to output :

...:1:1 Couldn't resolve type name 'constant/string'

which makes me think there is something wrong with the type name, but that's not the problem at all. The actual problem is the runner doesn't accept the 'label=' metadata.

Please consider changing the error message to something more representative of the actual error, eg:

Error parsing node: node9 - unexpected metadata 'label'
Unexpected metadata

FBP files containing unexpected metadata also cause the fbp runner to fail. Please consider changing this behaviour so that users can embed information that is useful for purposes that haven't been considered. Specifically, allowing label="node9" should be allowed, but a better solution would be to simply ignore metadata that is unexpected, else you'd be forcing developers of other tools to maintain input and output processors to make it so the file is acceptable as input to Soletta.

Thanks.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions