Skip to content
This repository was archived by the owner on Jun 27, 2019. It is now read-only.

Commit 84ecbbf

Browse files
author
Flavio Ceolin
committed
flow:http:server: Fix wrong comparation
sol_http_param_add() returns a boolean false in case of error. It was comparing with an integer < 0. Signed-off-by: Flavio Ceolin <[email protected]>
1 parent 49b268e commit 84ecbbf

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/modules/flow/http-server/http-server.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -296,10 +296,10 @@ common_response_cb(void *data, struct sol_http_request *request)
296296
"Could not serve request: %s", sol_util_strerrora(-r));
297297

298298
sol_http_params_clear(&response.param);
299-
r = sol_http_param_add(&response.param, SOL_HTTP_REQUEST_PARAM_HEADER(
300-
HTTP_HEADER_CONTENT_TYPE, HTTP_HEADER_CONTENT_TYPE_TEXT));
301-
if (r < 0)
299+
if (!sol_http_param_add(&response.param, SOL_HTTP_REQUEST_PARAM_HEADER(
300+
HTTP_HEADER_CONTENT_TYPE, HTTP_HEADER_CONTENT_TYPE_TEXT))) {
302301
SOL_WRN("could not set response content-type: text/plain: %s", sol_util_strerrora(-r));
302+
}
303303

304304
/* response_code was set before goto, so use as-is */
305305
sol_http_server_send_response(request, &response);

0 commit comments

Comments
 (0)