Skip to content

[INFRA] Set default SEQAN3_GENERATE_SNIPPETS to OFF #3356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2025
Merged

[INFRA] Set default SEQAN3_GENERATE_SNIPPETS to OFF #3356

merged 1 commit into from
Apr 1, 2025

Conversation

@eseiler
Copy link
Member

@eseiler eseiler commented Apr 1, 2025

No description provided.

@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Apr 1, 2025
@seqan-actions
Copy link
Member

seqan-actions commented Apr 1, 2025

Documentation preview available at https://docs.seqan.de/preview/seqan/seqan3/3356

@SGSSGene SGSSGene self-requested a review April 1, 2025 14:12
SGSSGene
SGSSGene requested changes Apr 1, 2025
View reviewed changes
Copy link
Contributor

@SGSSGene SGSSGene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Please rebase!

@eseiler eseiler force-pushed the infra/no_generate_snippets branch from 0dd9b16 to 4f0543b Compare April 1, 2025 14:13
@SGSSGene SGSSGene self-requested a review April 1, 2025 14:13
SGSSGene
SGSSGene approved these changes Apr 1, 2025
View reviewed changes
Copy link
Contributor

@SGSSGene SGSSGene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@eseiler eseiler force-pushed the infra/no_generate_snippets branch from 4f0543b to 7cf5cfc Compare April 1, 2025 14:13
@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Apr 1, 2025
@codecov
Copy link

codecov bot commented Apr 1, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.11%. Comparing base (2a9838f) to head (7cf5cfc).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3356   +/-   ##
=======================================
  Coverage   98.11%   98.11%           
=======================================
  Files         270      270           
  Lines       11913    11913           
  Branches      103      103           
=======================================
  Hits        11689    11689           
  Misses        224      224

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@eseiler eseiler merged commit e456fcb into seqan:main Apr 1, 2025
40 checks passed
@eseiler eseiler deleted the infra/no_generate_snippets branch April 1, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SGSSGene SGSSGene SGSSGene approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eseiler @seqan-actions @SGSSGene