Fix some gas warnings

ccojocar · ccojocar · commit c2c21553a313 · 2018-02-07T14:07:24.000+01:00
diff --git a/cmd/gas/main.go b/cmd/gas/main.go
@@ -149,9 +149,15 @@ func saveOutput(filename, format string, issues []*gas.Issue, metrics *gas.Metri
 			return err
 		}
 		defer outfile.Close()
-		output.CreateReport(outfile, format, issues, metrics)
+		err = output.CreateReport(outfile, format, issues, metrics)
+		if err != nil {
+			return err
+		}
 	} else {
-		output.CreateReport(os.Stdout, format, issues, metrics)
+		err := output.CreateReport(os.Stdout, format, issues, metrics)
+		if err != nil {
+			return err
+		}
 	}
 	return nil
 }
@@ -166,7 +172,7 @@ func main() {
 
 	// Ensure at least one file was specified
 	if flag.NArg() == 0 {
-		fmt.Fprintf(os.Stderr, "\nError: FILE [FILE...] or './...' expected\n")
+		fmt.Fprintf(os.Stderr, "\nError: FILE [FILE...] or './...' expected\n") // #nosec
 		flag.Usage()
 		os.Exit(1)
 	}
@@ -231,7 +237,7 @@ func main() {
 	}
 
 	// Finialize logging
-	logWriter.Close()
+	logWriter.Close() // #nosec
 
 	// Do we have an issue? If so exit 1
 	if issuesFound {
diff --git a/testutils/pkg.go b/testutils/pkg.go
@@ -128,6 +128,7 @@ func (p *TestPackage) CreateContext(filename string) *gas.Context {
 // Close will delete the package and all files in that directory
 func (p *TestPackage) Close() {
 	if p.ondisk {
-		os.RemoveAll(p.Path)
+		err := os.RemoveAll(p.Path)
+		log.Println(err)
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -128,6 +128,7 @@ func (p TestPackage) CreateContext(filename string) gas.Context {`
`128`	`128`	`// Close will delete the package and all files in that directory`
`129`	`129`	`func (p *TestPackage) Close() {`
`130`	`130`	`if p.ondisk {`
`131`		`- os.RemoveAll(p.Path)`
	`131`	`+ err := os.RemoveAll(p.Path)`
	`132`	`+ log.Println(err)`
`132`	`133`	`}`
`133`	`134`	`}`