Skip to content
This repository was archived by the owner on Sep 15, 2024. It is now read-only.

Commit dd53942

Browse files
sunilpaulmathewsunilpaulmathew
committed
Removed ACCESS_NETWORK_STATE permission from app
Signed-off-by: sunilpaulmathew <[email protected]>
1 parent d5ca587 commit dd53942

File tree

6 files changed

+13
-24
lines changed

6 files changed

+13
-24
lines changed

‎app/src/main/AndroidManifest.xml‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44

55
<uses-permission android:name="android.permission.INTERNET" />
66
<uses-permission android:name="android.permission.ACCESS_SUPERUSER" />
7-
<uses-permission android:name="android.permission.ACCESS_NETWORK_STATE" />
87
<uses-permission android:name="android.permission.REQUEST_INSTALL_PACKAGES" />
98
<uses-permission android:name="android.permission.SCHEDULE_EXACT_ALARM" />
109

‎app/src/main/java/com/nfs/nfsmanager/MainActivity.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ protected void onCreate(Bundle savedInstanceState) {
9393
getString(R.string.illegal_apps) : getString(R.string.sleeping));
9494
mUnsupportedImage.setOnClickListener(v -> {
9595
if (!Utils.rootAccess() || !NFS.magiskSupported()) {
96-
Utils.launchUrl(mBottomMenu, "https://www.google.com/search?site=&source=hp&q=android+rooting+magisk", this);
96+
Utils.launchUrl("https://www.google.com/search?site=&source=hp&q=android+rooting+magisk", this);
9797
} else {
9898
new MaterialAlertDialogBuilder(this)
9999
.setIcon(R.mipmap.ic_launcher)
@@ -110,7 +110,7 @@ protected void onCreate(Bundle savedInstanceState) {
110110

111111
mSettings.setOnClickListener(v -> settingsMenu());
112112

113-
mOffLineAd.setOnClickListener(v -> Utils.launchUrl(mBottomMenu, "https://t.me/nfsreleases/424", this));
113+
mOffLineAd.setOnClickListener(v -> Utils.launchUrl("https://t.me/nfsreleases/424", this));
114114

115115
mModuleImage.setImageDrawable(ContextCompat.getDrawable(this, R.mipmap.ic_launcher));
116116
mModuleTitle.setText(getString(R.string.module_version, NFS.getModVersion() +

‎app/src/main/java/com/nfs/nfsmanager/adapters/AboutAdapter.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,12 +82,12 @@ public void onBindViewHolder(@NonNull AboutAdapter.ViewHolder holder, int positi
8282
.setNegativeButton(R.string.cancel, (dialogInterface, ii) -> {
8383
})
8484
.setPositiveButton(R.string.donate, (dialogInterface, ii) ->
85-
Utils.launchUrl(holder.mRVLayout, "https://www.paypal.me/menacherry", holder.mRVLayout.getContext()))
85+
Utils.launchUrl("https://www.paypal.me/menacherry", holder.mRVLayout.getContext()))
8686
.show();
8787
} else if (position == 11) {
8888
UpdateCheck.initialize(0, false, holder.mRVLayout.getContext());
8989
} else if (this.data.get(position).getURL() != null) {
90-
Utils.launchUrl(holder.mRVLayout, this.data.get(position).getURL(), holder.mRVLayout.getContext());
90+
Utils.launchUrl(this.data.get(position).getURL(), holder.mRVLayout.getContext());
9191
}
9292
});
9393
}

‎app/src/main/java/com/nfs/nfsmanager/adapters/CreditsAdapter.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ public void onBindViewHolder(@NonNull CreditsAdapter.ViewHolder holder, int posi
4545
holder.mIcon.setImageDrawable(this.data.get(position).getIcon());
4646
holder.mRVLayout.setOnClickListener(v -> {
4747
if (this.data.get(position).getURL() != null) {
48-
Utils.launchUrl(holder.mRVLayout, this.data.get(position).getURL(), holder.mRVLayout.getContext());
48+
Utils.launchUrl(this.data.get(position).getURL(), holder.mRVLayout.getContext());
4949
}
5050
});
5151
}

‎app/src/main/java/com/nfs/nfsmanager/fragments/DashBoardFragment.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ public View onCreateView(LayoutInflater inflater, @Nullable ViewGroup container,
5757
} else if (position == 3) {
5858
showUpdateModeDialog(3, getString(R.string.gaming));
5959
} else if (position == 4) {
60-
Utils.launchUrl(mRootView, "https://github.com/k1ks/NFS-INJECTOR/wiki", requireActivity());
60+
Utils.launchUrl("https://github.com/k1ks/NFS-INJECTOR/wiki", requireActivity());
6161
}
6262
}
6363
});

‎app/src/main/java/com/nfs/nfsmanager/utils/Utils.java‎

Lines changed: 7 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -229,17 +229,13 @@ public static void indefiniteSnackbar(View view, String message) {
229229
snackbar.show();
230230
}
231231

232-
public static void launchUrl(View view, String url, Context context) {
233-
if (isNetworkUnavailable(context)) {
234-
longSnackbar(view, context.getString(R.string.no_internet));
235-
} else {
236-
try {
237-
Intent i = new Intent(Intent.ACTION_VIEW);
238-
i.setData(Uri.parse(url));
239-
context.startActivity(i);
240-
} catch (ActivityNotFoundException e) {
241-
e.printStackTrace();
242-
}
232+
public static void launchUrl(String url, Context context) {
233+
try {
234+
Intent i = new Intent(Intent.ACTION_VIEW);
235+
i.setData(Uri.parse(url));
236+
context.startActivity(i);
237+
} catch (ActivityNotFoundException e) {
238+
e.printStackTrace();
243239
}
244240
}
245241

@@ -253,12 +249,6 @@ public static boolean isTablet(Context context) {
253249
>= Configuration.SCREENLAYOUT_SIZE_LARGE;
254250
}
255251

256-
public static boolean isNetworkUnavailable(Context context) {
257-
ConnectivityManager cm = (ConnectivityManager) context.getSystemService(Context.CONNECTIVITY_SERVICE);
258-
assert cm != null;
259-
return (cm.getActiveNetworkInfo() == null) || !cm.getActiveNetworkInfo().isConnectedOrConnecting();
260-
}
261-
262252
public static String readAssetFile(Context context, String file) {
263253
InputStream input = null;
264254
BufferedReader buf = null;

0 commit comments

Comments
 (0)