chore: code suggestions

ematipico · ematipico · commit 515e09f0b1b8 · 2023-01-05T11:09:04.000Z
diff --git a/crates/rome_cli/tests/snapshots/main_reporter_json/reports_formatter_check_mode.snap b/crates/rome_cli/tests/snapshots/main_reporter_json/reports_formatter_check_mode.snap
@@ -11,7 +11,7 @@ expression: content
 # Emitted Messages
 
 ```block
-{"formatter":{"summary":{"filesCompared":1,"filesWritten":null},"files":{"format.js":{"formattedContent":"statement();\n"}}},"diagnostics":{"format.js":{"diff":{"severity":"Error","before":"  statement(  )  ","after":"statement();\n"}}}}
+{"formatter":{"summary":{"filesCompared":1,"filesWritten":null},"files":{"format.js":{"formattedContent":"statement();\n"}}},"diagnostics":{"format.js":{"diff":{"severity":"error","before":"  statement(  )  ","after":"statement();\n"}}}}
 ```
 
 
diff --git a/crates/rome_diagnostics/src/location.rs b/crates/rome_diagnostics/src/location.rs
@@ -58,7 +58,7 @@ impl<P> Resource<P> {
         P: Deref,
     {
         if let Resource::File(file) = self {
-            Some(file.deref())
+            Some(&*file)
         } else {
             None
         }
@@ -72,7 +72,7 @@ impl<P> Resource<P> {
         match self {
             Resource::Argv => Resource::Argv,
             Resource::Memory => Resource::Memory,
-            Resource::File(file) => Resource::File(file.deref()),
+            Resource::File(file) => Resource::File(&*file),
         }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,7 @@ impl<P> Resource<P> {`
`58`	`58`	`P: Deref,`
`59`	`59`	`{`
`60`	`60`	`if let Resource::File(file) = self {`
`61`		`- Some(file.deref())`
	`61`	`+ Some(&*file)`
`62`	`62`	`} else {`
`63`	`63`	`None`
`64`	`64`	`}`
`@@ -72,7 +72,7 @@ impl<P> Resource<P> {`
`72`	`72`	`match self {`
`73`	`73`	`Resource::Argv => Resource::Argv,`
`74`	`74`	`Resource::Memory => Resource::Memory,`
`75`		`- Resource::File(file) => Resource::File(file.deref()),`
	`75`	`+ Resource::File(file) => Resource::File(&*file),`
`76`	`76`	`}`
`77`	`77`	`}`
`78`	`78`	`}`