fix: preserve constant identifiers in unary expressions instead of magic numbers (#5968)

OmkarJ13 · lukastaegert · web-flow · commit 224c90071791 · 2025-06-06T05:00:44.000Z
* fix: preserve constant identifiers in unary expressions instead of magic numbers

* test: formatting

---------

Co-authored-by: Lukas Taegert-Atkinson &lt;lukastaegert@users.noreply.github.com&gt;
diff --git a/src/ast/nodes/UnaryExpression.ts b/src/ast/nodes/UnaryExpression.ts
@@ -114,9 +114,13 @@ export default class UnaryExpression extends NodeBase {
 	): void {
 		if (!this.deoptimized) this.applyDeoptimizations();
 		this.included = true;
+		// Check if the argument is an identifier that should be preserved as a reference for readability
+		const shouldPreserveArgument =
+			this.argument instanceof Identifier && this.argument.variable?.included;
 		if (
 			typeof this.getRenderedLiteralValue(includeChildrenRecursively) === 'symbol' ||
-			this.argument.shouldBeIncluded(context)
+			this.argument.shouldBeIncluded(context) ||
+			shouldPreserveArgument
 		) {
 			this.argument.include(context, includeChildrenRecursively);
 			this.renderedLiteralValue = UnknownValue;
diff --git a/test/form/samples/unary-expressions-preserve-constants/_config.js b/test/form/samples/unary-expressions-preserve-constants/_config.js
@@ -0,0 +1,4 @@
+module.exports = defineTest({
+	description:
+		'Preserves constant identifiers in unary expressions when constants are used elsewhere'
+});
diff --git a/test/form/samples/unary-expressions-preserve-constants/_expected.js b/test/form/samples/unary-expressions-preserve-constants/_expected.js
@@ -0,0 +1,25 @@
+const BOB = 3;
+const ALICE = 5;
+
+function getBob() {
+	return {x: BOB, y: -BOB, z: +BOB};
+}
+
+function getAlice() {
+	console.log(ALICE);
+	return ~ALICE;
+}
+
+// Test with different operators
+function testOperators() {
+	return {
+		negate: -BOB,
+		plus: +BOB, 
+		not: !BOB,
+		bitwise: ~BOB,
+		typeof: typeof BOB,
+		void: void BOB
+	};
+}
+
+export { ALICE, BOB, getAlice, getBob, testOperators };
diff --git a/test/form/samples/unary-expressions-preserve-constants/main.js b/test/form/samples/unary-expressions-preserve-constants/main.js
@@ -0,0 +1,23 @@
+export const BOB = 3;
+export const ALICE = 5;
+
+export function getBob() {
+	return {x: BOB, y: -BOB, z: +BOB};
+}
+
+export function getAlice() {
+	console.log(ALICE);
+	return ~ALICE;
+}
+
+// Test with different operators
+export function testOperators() {
+	return {
+		negate: -BOB,
+		plus: +BOB, 
+		not: !BOB,
+		bitwise: ~BOB,
+		typeof: typeof BOB,
+		void: void BOB
+	};
+}
