Add option to remove Bootstrap when creating project #1810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swalkinshaw
reviewed
Jan 14, 2017
|
|
||
| if (!$remove_bootstrap) { | ||
| return 1; | ||
| } |
Member
There was a problem hiding this comment.
Flip the default?
$io = $event->getIO();
if ($io->isInteractive()) {
if ($io->askConfirmation('<info>Remove Bootstrap?</info> [<comment>y,N</comment>]? ', false)) {
file_put_contents('package.json', str_replace(' "bootstrap": "^4.0.0-alpha.6",' . "\n", '', file_get_contents('package.json')));
file_put_contents('assets/styles/main.scss', str_replace('// Import npm dependencies' . "\n", '', file_get_contents('assets/styles/main.scss')));
file_put_contents('assets/styles/main.scss', str_replace('@import "~bootstrap/scss/bootstrap";' . "\n", '', file_get_contents('assets/styles/main.scss')));
file_put_contents('assets/scripts/main.js', str_replace('import \'bootstrap/dist/js/bootstrap\';' . "\n", '', file_get_contents('assets/scripts/main.js')));
file_put_contents('assets/styles/components/_comments.scss', '');
file_put_contents('assets/styles/components/_forms.scss', '');
file_put_contents('assets/styles/components/_wp-classes.scss', '');
file_put_contents('assets/styles/layouts/_header.scss', '');
}
}
swalkinshaw
reviewed
Jan 14, 2017
src/lib/Sage/PostCreateProject.php
Outdated
| file_put_contents('package.json', str_replace(' "bootstrap": "^4.0.0-alpha.6",' . "\n", '', file_get_contents('package.json'))); | ||
| file_put_contents('assets/styles/main.scss', str_replace('// Import npm dependencies' . "\n", '', file_get_contents('assets/styles/main.scss'))); | ||
| file_put_contents('assets/styles/main.scss', str_replace('@import "~bootstrap/scss/bootstrap";' . "\n", '', file_get_contents('assets/styles/main.scss'))); | ||
| file_put_contents('assets/scripts/main.js', str_replace('import \'bootstrap/dist/js/bootstrap\';' . "\n", '', file_get_contents('assets/scripts/main.js'))); |
Member
There was a problem hiding this comment.
"import 'bootstrap/dist/js/bootstrap';" will phpcs complain about this? :(
|
One step further? Instead of removing bootstrap, maybe we could choose between bootstrap, foundation, etc..? |
Member
Author
|
Working on it 😊
…Sent from my iPhone
On Jan 17, 2017, at 1:15 PM, Brandon Tamm ***@***.***> wrote:
One step further? Instead of removing bootstrap, maybe we could choose between bootstrap, foundation, etc..?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
@retlehs you're the man! On a side note - check out https://github.com/iamdb/bedrock-wordpress-docker. I build all my sites with this type of setup. I adapt it and script deployment processes, of course - may be of interest to you 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when creating a new sage project (
composer create-project roots/sage your-theme-name) you will be prompted:if yes, bootstrap is removed from:
package.jsonassets/styles/main.scssassets/scripts/main.jsassets/styles/components/_comments.scssassets/styles/components/_forms.scssassets/styles/components/_wp-classes.scssassets/styles/layouts/_header.scss