fix: enable connection revalidation to scale to more connections than can fit in memory at once #491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n can fit in memory at once
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
aboodman
reviewed
May 6, 2023
| } | ||
|
|
||
| const CONNECTION_KEY_PREFIX = 'connection/'; | ||
| const CONNECTION_ROOM_INDEX_PREFIX = 'connection_room/'; |
There was a problem hiding this comment.
I feel like connections_by_room would be a more immediately obvious name.
| return `${CONNECTION_KEY_PREFIX}${encodeURIComponent(userID)}/`; | ||
| } | ||
|
|
||
| function connectionKeyToConnectionRoomIndexString(key: ConnectionKey): string { |
There was a problem hiding this comment.
Do you purposely end it with /?
There was a problem hiding this comment.
i was just keeping this consistent with what I did for the connectionKeyToString and I can't remember why I ended that with slash.
| } | ||
|
|
||
| function connectionKeyToConnectionRoomIndexString(key: ConnectionKey): string { | ||
| return `${CONNECTION_ROOM_INDEX_PREFIX}${encodeURIComponent( |
There was a problem hiding this comment.
nit, but you could use the below function inside this function to ensure they remain in sync.
Problem
Monday's revalidate connections cron is failing every time due to it exceeding memory limits. This is because the full list of connections is too large to fit in memory.
Solution
Refactor the two places where the AuthDO lists all connections (
_authRevalidateConnectionsand_authInvalidateAll), to instead incrementally load the connections.For
_authRevalidateConnectionswe need to group the connections by roomID, since we revalidate connections a room at a time by fetching the room's current connections. To do this incrementally without having to iterate the entire list of connections incrementally for each room necessitates creating a new index by room id over the connections. To handle the creation of this index for existings AuthDO's, an AuthDO Storage Schema Version is introduced and stored in the AuthDO's storage at keyauth_do_storage_schema_version. The AuthDO ensures the storage schema version is upgraded to the current version before processing any fetch.Fixes #487