fix: enable block cache for hummock+s3 state store #355
Conversation
Codecov Report
@@ Coverage Diff @@
## main #355 +/- ##
============================================
- Coverage 74.23% 74.23% -0.01%
Complexity 2681 2681
============================================
Files 863 863
Lines 48830 48832 +2
Branches 1591 1591
============================================
- Hits 36250 36248 -2
- Misses 11767 11771 +4
Partials 813 813
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
MrCroxx
left a comment
There was a problem hiding this comment.
Why block cache was disabled before, are there any considerations, 0.0?
|
block cache was only implemented in minio previously |
skyzh
left a comment
There was a problem hiding this comment.
I think it's time to work on risingwave.toml. 65536 should be part of the config, instead of hard coding.
|
The block cache also needs some refactor... I would consider the current impl as a workaround. We should pass options to |
What's changed and what's your intention?
Checklist
Refer to a related PR or issue link (optional)