Skip to content

feat(dashboard): support mv query on dashboard #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 14, 2022
Merged

feat(dashboard): support mv query on dashboard #310

merged 2 commits into from
Feb 14, 2022

Conversation

@yezizp2012
Copy link
Member

@yezizp2012 yezizp2012 commented Feb 14, 2022 •
edited
Loading

What's changed and what's your intention?

As title, support MV filter on dashboard, associated MV will not be displayed by default except when Show associated MV checked.
image

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

close #253

@yezizp2012 yezizp2012 changed the title feat: support mv query on dashboard feat(dashboard): support mv query on dashboard Feb 14, 2022
@github-actions github-actions bot added the type/feature Type: New feature. label Feb 14, 2022
BugenZhao
BugenZhao approved these changes Feb 14, 2022
View reviewed changes
Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LSTM! Why would a boy say no to the web frontend?

@codecov
Copy link

codecov bot commented Feb 14, 2022 •
edited
Loading

Codecov Report

Merging #310 (8a52b5e) into main (1e09917) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #310      +/-   ##
============================================
- Coverage     74.25%   74.22%   -0.04%     
  Complexity     2665     2665              
============================================
  Files           854      855       +1     
  Lines         48338    48381      +43     
  Branches       1586     1586              
============================================
+ Hits          35894    35910      +16     
- Misses        11632    11659      +27     
  Partials        812      812
Flag Coverage Δ
java 61.93% <0.00%> (ø)
rust 79.50% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../main/java/com/risingwave/catalog/CatalogCast.java 0.00% <0.00%> (ø)
rust/meta/src/dashboard/mod.rs 0.00% <0.00%> (ø)
rust/meta/src/rpc/server.rs 88.52% <0.00%> (-1.48%) ⬇️
rust/meta/src/stream/meta.rs 56.16% <0.00%> (-2.41%) ⬇️
rust/common/src/types/ordered_float.rs 25.49% <0.00%> (-0.34%) ⬇️
rust/connector/src/kinesis/source/reader.rs 0.00% <0.00%> (ø)
rust/connector/src/kinesis/source/state.rs 80.95% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e09917...8a52b5e. Read the comment docs.

@yezizp2012 yezizp2012 enabled auto-merge (squash) February 14, 2022 11:39
@yezizp2012 yezizp2012 merged commit 8aa2f3e into main Feb 14, 2022
@yezizp2012 yezizp2012 deleted the feat/support-mv-query branch February 14, 2022 11:55
@MrCroxx MrCroxx mentioned this pull request Feb 16, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BugenZhao BugenZhao BugenZhao approved these changes

@cloudcarver cloudcarver cloudcarver approved these changes

@skyzh skyzh Awaiting requested review from skyzh

Assignees

No one assigned

Labels

type/feature Type: New feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

meta: associate MV with actors

5 participants

@yezizp2012 @skyzh @BugenZhao @cloudcarver