Skip to content

fix: set reasonable intervals for state store stats #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2022
Merged

fix: set reasonable intervals for state store stats #229

merged 1 commit into from
Feb 10, 2022

Conversation

@Sunt-ing
Copy link
Contributor

@Sunt-ing Sunt-ing commented Feb 10, 2022 •
edited
Loading

What's changed and what's your intention?

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@Sunt-ing Sunt-ing requested a review from wcy-fdu February 10, 2022 11:32
@github-actions github-actions bot added the type/fix Type: Bug fix. Only for pull requests. label Feb 10, 2022
@codecov
Copy link

codecov bot commented Feb 10, 2022

Codecov Report

Merging #229 (e92eb82) into main (8cf3034) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #229   +/-   ##
=========================================
  Coverage     74.56%   74.57%           
  Complexity     2656     2656           
=========================================
  Files           840      840           
  Lines         47959    47965    +6     
  Branches       1566     1566           
=========================================
+ Hits          35762    35768    +6     
  Misses        11397    11397           
  Partials        800      800
Flag Coverage Δ
java 62.04% <ø> (ø)
rust 79.97% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/storage/src/monitor/state_store_stats.rs 100.00% <100.00%> (ø)
rust/common/src/types/ordered_float.rs 25.49% <0.00%> (-0.34%) ⬇️
rust/stream/src/executor/barrier_align.rs 78.78% <0.00%> (ø)
rust/meta/src/hummock/compaction.rs 73.82% <0.00%> (+0.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cf3034...e92eb82. Read the comment docs.

wcy-fdu
wcy-fdu approved these changes Feb 10, 2022
View reviewed changes
Copy link
Contributor

@wcy-fdu wcy-fdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sunt-ing Sunt-ing merged commit 05f4eba into main Feb 10, 2022
@Sunt-ing Sunt-ing deleted the sunt_modify_bucket branch February 10, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wcy-fdu wcy-fdu wcy-fdu approved these changes

Assignees

No one assigned

Labels

type/fix Type: Bug fix. Only for pull requests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Sunt-ing @wcy-fdu