Skip to content

feat: introduce config in batch env and use chunk_size in config #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 9, 2022
Merged

feat: introduce config in batch env and use chunk_size in config #157

merged 5 commits into from
Feb 9, 2022

Conversation

@fuyufjh
Copy link
Collaborator

@fuyufjh fuyufjh commented Feb 9, 2022

What's changed and what's your intention?

  1. Simplify ComputeNodeConfig, making fields public
  2. Introduce BatchConfig into BatchTaskEnv
  3. Use chunk_size for ValuesExecutor

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@github-actions github-actions bot added the type/feature Type: New feature. label Feb 9, 2022
@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #157 (8e66109) into main (c082cb6) will increase coverage by 0.21%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #157      +/-   ##
============================================
+ Coverage     74.44%   74.66%   +0.21%     
  Complexity     2654     2654              
============================================
  Files           833      834       +1     
  Lines         47835    47883      +48     
  Branches       1562     1562              
============================================
+ Hits          35612    35753     +141     
+ Misses        11424    11331      -93     
  Partials        799      799
Flag Coverage Δ
java 62.08% <ø> (ø)
rust 80.09% <100.00%> (+0.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/batch/src/executor/values.rs 86.90% <100.00%> (ø)
rust/batch/src/task/env.rs 80.95% <100.00%> (+3.17%) ⬆️
rust/common/src/config.rs 56.25% <100.00%> (+6.25%) ⬆️
rust/server/src/server.rs 71.01% <100.00%> (+0.86%) ⬆️
rust/frontend/src/catalog/column_catalog.rs 28.57% <0.00%> (-3.01%) ⬇️
rust/stream/src/task/barrier_manager.rs 94.44% <0.00%> (-1.07%) ⬇️
rust/meta/src/model/mod.rs 80.00% <0.00%> (ø)
rust/meta/src/cluster/mod.rs 78.37% <0.00%> (ø)
rust/meta/src/stream/meta.rs 58.57% <0.00%> (ø)
rust/storage/src/keyspace.rs 85.45% <0.00%> (ø)
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c082cb6...8e66109. Read the comment docs.

neverchanje
neverchanje approved these changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@neverchanje neverchanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fuyufjh fuyufjh merged commit 2c357dc into main Feb 9, 2022
@fuyufjh fuyufjh deleted the eric/introduce-context branch February 9, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@neverchanje neverchanje neverchanje approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

type/feature Type: New feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fuyufjh @neverchanje