fix(streaming): ignore notifier send error of local barrier manager #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyzh
approved these changes
Feb 8, 2022
Codecov Report
@@ Coverage Diff @@
## main #152 +/- ##
=========================================
Coverage 74.44% 74.44%
Complexity 2654 2654
=========================================
Files 833 833
Lines 47835 47836 +1
Branches 1562 1562
=========================================
+ Hits 35612 35613 +1
Misses 11424 11424
Partials 799 799
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
Sometimes the rx of notifier is dropped unexpectedly due to shutdown or some other reasons. We may ignore this send error.
Checklist
Refer to a related PR or issue link (optional)
Failing example: https://github.com/singularity-data/risingwave-dev/runs/5105442552?check_suite_focus=true