Skip to content

feat(meta): Implement create/drop MV service v2 #983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 16, 2022
Merged

feat(meta): Implement create/drop MV service v2 #983

merged 4 commits into from
Mar 16, 2022

Conversation

@zbzbw
Copy link
Contributor

@zbzbw zbzbw commented Mar 16, 2022

Signed-off-by: Bowen Zhou [email protected]

What's changed and what's your intention?

This PR implements create and drop MV in catalog service v2 and does some simple refactoring.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

#866

@github-actions github-actions bot added the type/feature Type: New feature. label Mar 16, 2022
yezizp2012
yezizp2012 approved these changes Mar 16, 2022
View reviewed changes
Copy link
Member

@yezizp2012 yezizp2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Mar 16, 2022 •
edited
Loading

Codecov Report

Merging #983 (cffdb9f) into main (6cf429d) will decrease coverage by 0.19%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main     #983      +/-   ##
============================================
- Coverage     71.66%   71.47%   -0.20%     
  Complexity     2766     2766              
============================================
  Files           974      973       -1     
  Lines         57115    57215     +100     
  Branches       1790     1790              
============================================
- Hits          40933    40895      -38     
- Misses        15291    15429     +138     
  Partials        891      891
Flag Coverage Δ
java 61.03% <ø> (ø)
rust 75.48% <0.00%> (-0.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/meta/src/manager/catalog_v2.rs 0.00% <0.00%> (ø)
rust/meta/src/rpc/service/catalog_service_v2.rs 0.00% <0.00%> (ø)
...frontend/src/optimizer/plan_node/plan_tree_node.rs 30.00% <0.00%> (-48.00%) ⬇️
...end/src/optimizer/plan_node/stream_table_source.rs 81.81% <0.00%> (-18.19%) ⬇️
.../frontend/src/optimizer/plan_node/stream_filter.rs 72.22% <0.00%> (-14.45%) ⬇️
...frontend/src/optimizer/plan_node/stream_project.rs 56.25% <0.00%> (-12.99%) ⬇️
rust/frontend/src/optimizer/property/order.rs 90.24% <0.00%> (-4.88%) ⬇️
rust/meta/src/barrier/mod.rs 68.00% <0.00%> (-4.19%) ⬇️
...st/frontend/src/optimizer/property/distribution.rs 68.75% <0.00%> (-4.17%) ⬇️
rust/meta/src/stream/meta.rs 47.05% <0.00%> (-1.81%) ⬇️
... and 34 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

BugenZhao
BugenZhao reviewed Mar 16, 2022
View reviewed changes
BugenZhao
BugenZhao approved these changes Mar 16, 2022
View reviewed changes
Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM! Good work.

We may test this along with the Create MV handler. cc @skyzh

@BugenZhao BugenZhao requested a review from xx01cyx March 16, 2022 09:51
fix StoredClusterManagerRef
cffdb9f 
Signed-off-by: Bowen Zhou <[email protected]>
xx01cyx
xx01cyx approved these changes Mar 16, 2022
View reviewed changes
Copy link
Contributor

@xx01cyx xx01cyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zbzbw zbzbw enabled auto-merge (squash) March 16, 2022 10:00
@zbzbw zbzbw merged commit af6ba2e into main Mar 16, 2022
@zbzbw zbzbw deleted the zbw/catalog_service_v2_mv branch March 16, 2022 10:16
@BugenZhao BugenZhao mentioned this pull request Mar 17, 2022
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yezizp2012 yezizp2012 yezizp2012 approved these changes

@BugenZhao BugenZhao BugenZhao approved these changes

@st1page st1page Awaiting requested review from st1page

+1 more reviewer

@xx01cyx xx01cyx xx01cyx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

type/feature Type: New feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zbzbw @yezizp2012 @BugenZhao @xx01cyx