feat: support DELETE with the Java frontend
#962
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #962 +/- ##
============================================
- Coverage 71.80% 71.72% -0.08%
Complexity 2766 2766
============================================
Files 971 973 +2
Lines 56773 56862 +89
Branches 1787 1790 +3
============================================
+ Hits 40767 40787 +20
- Misses 15116 15184 +68
- Partials 890 891 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
fuyufjh
approved these changes
Mar 16, 2022
| use crate::executor::{BoxedExecutorBuilder, Executor, ExecutorBuilder}; | ||
|
|
||
| /// [`DeleteExecutor`] implements table deletion with values from its child executor. | ||
| // TODO: concurrent `DELETE` may cause problems. A scheduler might be required. |
Collaborator
There was a problem hiding this comment.
Indeed. So maybe we have to validate the input stream even for the TableSource (like other CDC sources)? Or introduce a table-level read-write lock? Need some discussions later.
wyhyhyhyh
reviewed
Mar 16, 2022
| ---- | ||
| 114 10 | ||
| 514 20 | ||
| 810 40 |
Contributor
There was a problem hiding this comment.
Stinky numbers as always.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
This PR implements
LogicalDeleteandRwBatchDeletein the Java frontend, and add amodify.sltto test the insertions and deletions for table v2.There's a workaround in the frontend named
patchScanfor scanning the hidden column as well for the delete executor.There might be the possibility of bugs for handling
DELETEin the implementations of some other executors. Therefore, the tests in this PR are relatively simple and no other MV is created. We may test and fix those in the next PRs. (#963)Checklist
Refer to a related PR or issue link (optional)
DELETEin TableV2 #16.