feat(optimizer): turn on HeuristicOptimizer #942
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #942 +/- ##
============================================
+ Coverage 71.49% 71.81% +0.32%
Complexity 2766 2766
============================================
Files 970 971 +1
Lines 56587 56636 +49
Branches 1787 1787
============================================
+ Hits 40457 40674 +217
+ Misses 15240 15072 -168
Partials 890 890
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
fuyufjh
approved these changes
Mar 15, 2022
|
|
||
| /// `PlanPass` receive a plan tree and transform it to a new one. | ||
| trait PlanPass { | ||
| pub trait PlanPass { |
Collaborator
There was a problem hiding this comment.
(unrelated to this PR) The trait PlanPass seems somehow over-designed to me. It mostly fits the volcano optimizer, but not so suitable for heuristic optimizer or visitors (like Pruning columns). Furthermore, we don't need to organize these 'phases' into a Vec or something. I would recommend removing it now and add back if necessary someday.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
HeuristicOptimizer(only filter join rule now)inputs_distribution/order_required, and remove default impls (not used)Checklist
Refer to a related PR or issue link (optional)