Skip to content

feat(optimzier): col_prune for logical insert #933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2022
Merged

feat(optimzier): col_prune for logical insert #933

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions rust/frontend/src/optimizer/plan_node/logical_insert.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
use std::fmt;

use fixedbitset::FixedBitSet;
use risingwave_common::catalog::{Field, Schema};
use risingwave_common::error::Result;
use risingwave_common::types::DataType;
Expand Down Expand Up @@ -63,9 +64,10 @@ impl fmt::Display for LogicalInsert {
}

impl ColPrunable for LogicalInsert {
fn prune_col(&self, required_cols: &fixedbitset::FixedBitSet) -> PlanRef {
// TODO: special handling for insert column pruning
self.clone_with_input(self.input.prune_col(required_cols))
fn prune_col(&self, _required_cols: &FixedBitSet) -> PlanRef {
let mut all_cols = FixedBitSet::with_capacity(self.input.schema().len());
all_cols.insert_range(..);
self.clone_with_input(self.input.prune_col(&all_cols))
.into()
}
}
Expand Down