Skip to content

Conversation

@st1page
Copy link
Contributor

@st1page st1page commented Mar 15, 2022

What's changed and what's your intention?

column prune for logical insert to prune its input with all column required

@st1page st1page requested review from BugenZhao, fuyufjh and skyzh March 15, 2022 09:18
@github-actions github-actions bot added the type/feature Type: New feature. label Mar 15, 2022
Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L💦TM!

@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #933 (8fba09c) into main (158b03e) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main     #933      +/-   ##
============================================
- Coverage     71.49%   71.48%   -0.01%     
  Complexity     2766     2766              
============================================
  Files           970      970              
  Lines         56587    56589       +2     
  Branches       1787     1787              
============================================
- Hits          40457    40455       -2     
- Misses        15240    15244       +4     
  Partials        890      890              
Flag Coverage Δ
java 61.23% <ø> (ø)
rust 75.45% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...frontend/src/optimizer/plan_node/logical_insert.rs 52.38% <0.00%> (-5.52%) ⬇️
rust/meta/src/hummock/compaction.rs 81.56% <0.00%> (-0.56%) ⬇️
rust/common/src/types/ordered_float.rs 25.49% <0.00%> (-0.34%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@st1page st1page merged commit 2cd821d into main Mar 15, 2022
@st1page st1page deleted the sts/optimizer_fix_col_prune_for_insert branch March 15, 2022 11:41
@xxchan xxchan mentioned this pull request Mar 15, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/feature Type: New feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants