Skip to content

feat(expr): support max, min, count for timestamptz #9165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 13, 2023
Merged

feat(expr): support max, min, count for timestamptz #9165

merged 1 commit into from
Apr 13, 2023

Conversation

@lmatz
Copy link
Contributor

@lmatz lmatz commented Apr 13, 2023 •
edited
Loading

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

As per the title.

Checklist For Contributors

- [ ] I have written necessary rustdoc comments

  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
  • All checks passed in ./risedev check (or alias, ./risedev c)

Checklist For Reviewers

- [ ] I have requested macro/micro-benchmarks as this PR can affect performance substantially, and the results are shown.

Documentation

Click here for Documentation

Types of user-facing changes

Please keep the types that apply to your changes, and remove the others.

  • SQL commands, functions, and operators

Release note

Add support for max(timestamptz), min(timestamptz) and count(timestamptz)

@github-actions github-actions bot added the type/feature Type: New feature. label Apr 13, 2023
@lmatz lmatz requested a review from xiangjinwu April 13, 2023 09:25
@codecov
Copy link

codecov bot commented Apr 13, 2023 •
edited
Loading

Codecov Report

Merging #9165 (0510f90) into main (9bf890a) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #9165      +/-   ##
==========================================
- Coverage   70.86%   70.85%   -0.02%     
==========================================
  Files        1200     1200              
  Lines      199974   199977       +3     
==========================================
- Hits       141711   141691      -20     
- Misses      58263    58286      +23
Flag Coverage Δ
rust 70.85% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/expr/src/vector_op/agg/aggregator.rs 56.17% <0.00%> (-0.97%) ⬇️

... and 11 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions github-actions bot added the user-facing-changes Contains changes that are visible to users label Apr 13, 2023
@lmatz lmatz added this pull request to the merge queue Apr 13, 2023
Merged via the queue into main with commit 62a76ab Apr 13, 2023
@lmatz lmatz deleted the lz/timestamptz branch April 13, 2023 10:27
@hengm3467 hengm3467 added the 📖✓ Covered or will be covered in the user docs. label Apr 26, 2023
@hengm3467 hengm3467 mentioned this pull request Apr 26, 2023
Closed
@bernscode bernscode mentioned this pull request May 3, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xiangjinwu xiangjinwu xiangjinwu approved these changes

Assignees

No one assigned

Labels

type/feature Type: New feature. user-facing-changes Contains changes that are visible to users 📖✓ Covered or will be covered in the user docs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lmatz @xiangjinwu @hengm3467