Skip to content

feat(frontend): support indexes on pure expressions #9142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 18, 2023
Merged

feat(frontend): support indexes on pure expressions #9142

merged 5 commits into from
Apr 18, 2023

Conversation

@chenzl25
Copy link
Contributor

@chenzl25 chenzl25 commented Apr 12, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist For Contributors

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
  • All checks passed in ./risedev check (or alias, ./risedev c)

Checklist For Reviewers

  • I have requested macro/micro-benchmarks as this PR can affect performance substantially, and the results are shown.

Documentation

  • My PR DOES NOT contain user-facing changes.
Click here for Documentation

Types of user-facing changes

Please keep the types that apply to your changes, and remove the others.

  • Installation and deployment
  • Connector (sources & sinks)
  • SQL commands, functions, and operators
  • RisingWave cluster configuration changes
  • Other (please specify in the release note below)

Release note

@github-actions github-actions bot added the type/feature Type: New feature. label Apr 12, 2023
@chenzl25 chenzl25 mentioned this pull request Apr 12, 2023
Closed
4 tasks
@chenzl25 chenzl25 requested review from st1page and xiangjinwu April 12, 2023 13:26
@codecov
Copy link

codecov bot commented Apr 12, 2023 •
edited
Loading

Codecov Report

Merging #9142 (d5d8cc1) into main (a76cae7) will increase coverage by 0.00%.
The diff coverage is 33.33%.

@@           Coverage Diff           @@
##             main    #9142   +/-   ##
=======================================
  Coverage   70.74%   70.74%           
=======================================
  Files        1208     1208           
  Lines      201535   201525   -10     
=======================================
- Hits       142577   142571    -6     
+ Misses      58958    58954    -4
Flag Coverage Δ
rust 70.74% <33.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/frontend/src/handler/create_index.rs 88.47% <33.33%> (+1.00%) ⬆️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@chenzl25 chenzl25 changed the title feat(frontend): support indexes on expressions feat(frontend): support indexes on pure expressions Apr 18, 2023
@chenzl25 chenzl25 requested a review from BugenZhao April 18, 2023 07:32
@chenzl25 chenzl25 enabled auto-merge April 18, 2023 07:55
@chenzl25 chenzl25 added this pull request to the merge queue Apr 18, 2023
Merged via the queue into main with commit a70363f Apr 18, 2023
@chenzl25 chenzl25 deleted the dylan/support_indexes_on_expressions branch April 18, 2023 08:39
@fuyufjh fuyufjh added the user-facing-changes Contains changes that are visible to users label Apr 19, 2023
@hengm3467 hengm3467 mentioned this pull request Apr 26, 2023
Closed
@hengm3467 hengm3467 added the 📖✓ Covered or will be covered in the user docs. label Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BugenZhao BugenZhao BugenZhao approved these changes

@xiangjinwu xiangjinwu Awaiting requested review from xiangjinwu

+1 more reviewer

@st1page st1page st1page approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

type/feature Type: New feature. user-facing-changes Contains changes that are visible to users 📖✓ Covered or will be covered in the user docs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@chenzl25 @BugenZhao @st1page @fuyufjh @hengm3467