feat(frontend): create query handler #907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #907 +/- ##
============================================
- Coverage 72.49% 72.44% -0.05%
Complexity 2766 2766
============================================
Files 936 937 +1
Lines 55268 55322 +54
Branches 1787 1787
============================================
+ Hits 40067 40079 +12
- Misses 14311 14353 +42
Partials 890 890
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
a351bfd to
f87d911
Compare
neverchanje
reviewed
Mar 15, 2022
| impl ToBatchProst for BatchProject { | ||
| fn to_batch_prost_body(&self) -> NodeBody { | ||
| NodeBody::Project(ProjectNode { | ||
| select_list: vec![], |
Contributor
There was a problem hiding this comment.
Suggested change
| select_list: vec![], | |
| select_list: self.logical.exprs.iter().map(|e| e.to_prost()), |
You can fully implement this in later pr, it should not be left blank.
I've glanced at ExprImpl and it seems to have no to_prost, it'd need some work.
neverchanje
approved these changes
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
implement query handler
Checklist
Refer to a related PR or issue link (optional)
#698