Skip to content

Conversation

@lmatz
Copy link
Contributor

@lmatz lmatz commented Mar 14, 2022

What's changed and what's your intention?

PLEASE DO NOT LEAVE THIS EMPTY !!!

Please explain IN DETAIL what the changes are in this PR and why they are needed:
Transform a single_value aggregation into a two-phase aggregation.

single_value is a special aggregation function that should not take any group key. Therefore, it is always a simple aggregation.

Refer to a related PR or issue link (optional)

#831

@github-actions github-actions bot added the type/feature Type: New feature. label Mar 14, 2022
Copy link
Contributor

@TennyZhuang TennyZhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lmatz lmatz enabled auto-merge (squash) March 14, 2022 08:02
@lmatz lmatz merged commit 3f03daf into main Mar 14, 2022
@lmatz lmatz deleted the lz/agg branch March 14, 2022 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/feature Type: New feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants