Skip to content

Conversation

@skyzh
Copy link
Contributor

@skyzh skyzh commented Mar 11, 2022

Signed-off-by: Alex Chi [email protected]

What's changed and what's your intention?

With all-in-one binary mode enabled, we can now call:

.bin/risectl

to use risectl.

This PR also fixes the bug that frontend-v2 cannot be started in all-in-one mode.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@skyzh skyzh requested a review from TennyZhuang March 11, 2022 06:45
@github-actions github-actions bot added the type/feature Type: New feature. label Mar 11, 2022
@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #857 (6bdc1ce) into main (77d143d) will not change coverage.
The diff coverage is n/a.

❗ Current head 6bdc1ce differs from pull request most recent head 715cd3a. Consider uploading reports for the commit 715cd3a to get more accurate results

@@            Coverage Diff            @@
##               main     #857   +/-   ##
=========================================
  Coverage     71.96%   71.96%           
  Complexity     2766     2766           
=========================================
  Files           927      927           
  Lines         54127    54127           
  Branches       1787     1787           
=========================================
  Hits          38952    38952           
  Misses        14285    14285           
  Partials        890      890           
Flag Coverage Δ
java 61.22% <ø> (ø)
rust 76.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/meta/src/hummock/compaction.rs 81.65% <0.00%> (-0.60%) ⬇️
rust/common/src/types/ordered_float.rs 25.82% <0.00%> (+0.33%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@skyzh skyzh force-pushed the skyzh/link-to-bin branch from 6bdc1ce to 715cd3a Compare March 11, 2022 07:04
@skyzh skyzh enabled auto-merge (squash) March 11, 2022 07:04
@skyzh skyzh merged commit c50e198 into main Mar 11, 2022
@skyzh skyzh deleted the skyzh/link-to-bin branch March 11, 2022 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/feature Type: New feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants