Skip to content

feat(streaming): add unit tests for lookup executor #851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2022
Merged

feat(streaming): add unit tests for lookup executor #851

merged 1 commit into from
Mar 11, 2022

Conversation

@skyzh
Copy link
Contributor

@skyzh skyzh commented Mar 11, 2022

Signed-off-by: Alex Chi [email protected]

What's changed and what's your intention?

As title.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

#719

@github-actions github-actions bot added the type/feature Type: New feature. label Mar 11, 2022
@skyzh skyzh mentioned this pull request Mar 11, 2022
Closed
@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #851 (36b4966) into main (81f1686) will increase coverage by 0.19%.
The diff coverage is 91.27%.

@@             Coverage Diff              @@
##               main     #851      +/-   ##
============================================
+ Coverage     72.02%   72.21%   +0.19%     
  Complexity     2766     2766              
============================================
  Files           927      928       +1     
  Lines         54086    54272     +186     
  Branches       1787     1787              
============================================
+ Hits          38953    39194     +241     
+ Misses        14243    14188      -55     
  Partials        890      890
Flag Coverage Δ
java 61.22% <ø> (ø)
rust 76.72% <91.27%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/stream/src/executor/lookup.rs 16.66% <0.00%> (+16.66%) ⬆️
rust/stream/src/executor/lookup/sides.rs 39.47% <0.00%> (+39.47%) ⬆️
rust/stream/src/executor/mod.rs 72.81% <75.00%> (+0.08%) ⬆️
rust/stream/src/executor/lookup/impl_.rs 78.35% <77.14%> (+78.35%) ⬆️
rust/stream/src/executor/lookup/tests.rs 100.00% <100.00%> (ø)
rust/frontend/src/observer/observer_manager.rs 85.71% <0.00%> (-0.96%) ⬇️
rust/common/src/types/ordered_float.rs 25.49% <0.00%> (-0.34%) ⬇️
rust/meta/src/manager/catalog_v2.rs 0.00% <0.00%> (ø)
rust/storage/src/keyspace.rs 80.30% <0.00%> (+3.03%) ⬆️
rust/common/src/util/ordered/serde.rs 83.15% <0.00%> (+3.26%) ⬆️
... and 5 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@skyzh skyzh merged commit cc9f4a9 into main Mar 11, 2022
@skyzh skyzh deleted the skyzh/finish-lookup branch March 11, 2022 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fuyufjh fuyufjh fuyufjh approved these changes

@TennyZhuang TennyZhuang Awaiting requested review from TennyZhuang

@BugenZhao BugenZhao Awaiting requested review from BugenZhao

Assignees

No one assigned

Labels

type/feature Type: New feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@skyzh @fuyufjh